Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] CI on nvhpc, the NVIDIA HPC compilers #237

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[feature] CI on nvhpc, the NVIDIA HPC compilers #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
252fa05
[feature] CI on nvhpc, the NVIDIA HPC compilers
perarnau Sep 17, 2024
9779190
fixes
perarnau Sep 17, 2024
4941311
dumb container
perarnau Sep 17, 2024
e27b19d
container shell
perarnau Sep 17, 2024
87f887c
something funny going on
perarnau Sep 17, 2024
e7f7b61
shell weirdness
perarnau Sep 17, 2024
0c01447
typo
perarnau Sep 17, 2024
c6d3205
env vars
perarnau Sep 17, 2024
14573e1
git-version-gen bug
perarnau Sep 18, 2024
9aeb9fc
typo
perarnau Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 43 additions & 6 deletions .github/workflows/builds.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- run: make
- run: make check
- run: make install
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: generic
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
working-directory: out
- run: make check
working-directory: out
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: out-of-tree
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
HWLOC_CPUID_PATH: ${{ github.workspace }}/cpuid
VALGRIND_SUPPRESSIONS_FILES: ${{ github.workspace }}/.valgrind.supp
OMP_NUM_THREADS: 1
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: valgrind
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
HWLOC_CPUID_PATH: ${{ github.workspace }}/cpuid
VALGRIND_SUPPRESSIONS_FILES: ${{ github.workspace }}/.valgrind.supp
OMP_NUM_THREADS: 1
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: valgrind
Expand Down Expand Up @@ -147,7 +147,7 @@ jobs:
mkdir build
./configure --prefix=`pwd`/build --without-rocm
- run: make distcheck
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: distcheck
Expand All @@ -173,7 +173,44 @@ jobs:
- run: make CFLAGS=-std=c99
- run: make check
- run: make install
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: rocm
path: |
config.log
tests/*.log
benchmarks/*.log
doc/tutorials/*.log
nvhpc:
env:
CFLAGS: "-std=c99"
runs-on: ubuntu-latest
defaults:
run:
shell: bash
container:
image: nvcr.io/nvidia/nvhpc:24.7-devel-cuda12.5-ubuntu22.04
steps:
- uses: actions/checkout@v2
with:
submodules: true
fetch-depth: 0
- run: apt-get update
- run: apt-get install -y make autoconf automake libtool pkgconf libhwloc-dev
- run: |
echo "0.8.0" > .tarball-version
- name: build
run: |
source /usr/share/lmod/6.6/init/bash
module load nvhpc
./autogen.sh
mkdir build
./configure --prefix=`pwd`/build --with-cuda CUDA_HOME=$NVHPC_ROOT/cuda
make
make check
make install
- uses: actions/upload-artifact@v4
if: failure()
with:
name: rocm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
export LD_LIBRARY_PATH=$GITHUB_WORKSPACE/$INSTALL_PATH/lib:$LD_LIBRARY_PATH
cd xsbench/openmp-threading
test -n "$(./XSBench -s small | grep 'Verification checksum' | grep -i valid)"
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v4
if: failure()
with:
name: generic
Expand Down
9 changes: 6 additions & 3 deletions benchmarks/blas/l1_kernel.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,18 @@ double ddot(size_t n, double *a, double *b, double *c, double scalar)
(void)*c;
(void)scalar;
size_t i;
long double dot = 0.0;
/* should be a long double for overflow checks, but some compilers (nvc)
* don't support reduce on long double in 2024.
*/
double dot = 0.0;

#pragma omp parallel for reduction(+ : dot)
for (i = 0; i < n; i++) {
long double temp;
double temp;
temp = a[i] * b[i];
dot += temp;
}
return (double)dot;
return dot;
}

double dnrm2(size_t n, double *a, double *b, double *c, double scalar)
Expand Down
2 changes: 1 addition & 1 deletion excit
Open in desktop
Submodule excit updated 40 files
+104 −0 .clang-format
+109 −0 .github/workflows/builds.yml
+27 −0 .github/workflows/style.yml
+0 −11 .gitlab-ci.yml
+20 −0 .licenserc.yml
+0 −3 .repoquality
+12 −0 .valgrind.supp
+0 −2 src/Makefile.am
+2 −2 src/composition.c
+2 −2 src/composition.h
+2 −2 src/cons.c
+2 −2 src/cons.h
+2 −2 src/excit.c
+2 −2 src/excit.h
+2 −2 src/hilbert2d.c
+2 −2 src/hilbert2d.h
+2 −2 src/index.c
+2 −2 src/index.h
+2 −2 src/loop.c
+2 −2 src/loop.h
+2 −2 src/prod.c
+2 −2 src/prod.h
+2 −2 src/range.c
+2 −2 src/range.h
+2 −2 src/repeat.c
+2 −2 src/repeat.h
+2 −2 src/tleaf.c
+2 −2 src/tleaf.h
+1 −1 tests/Makefile.am
+2 −3 tests/excit_composition.c
+2 −2 tests/excit_cons.c
+2 −2 tests/excit_hilbert2d.c
+2 −2 tests/excit_index.c
+2 −2 tests/excit_loop.c
+2 −2 tests/excit_product.c
+2 −2 tests/excit_range.c
+2 −2 tests/excit_repeat.c
+2 −2 tests/excit_test.c
+2 −2 tests/excit_test.h
+2 −2 tests/excit_tleaf.c
9 changes: 4 additions & 5 deletions src/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,10 @@ endif
# Cuda sources

if HAVE_CUDA
libcuda_la_SOURCES=area/cuda.c dma/cuda.c
noinst_LTLIBRARIES+=libcuda.la
libcuda_la_CPPFLAGS=$(AM_CPPFLAGS) $(CUDA_CFLAGS)
libcuda_la_LDFLAGS=$(AM_LDFLAGS) $(CUDA_LIBS)
libaml_la_LIBADD=libcuda.la
AM_CPPFLAGS += $(CUDA_CFLAGS)
AM_LDFLAGS += $(CUDA_LIBS)
libaml_la_SOURCES+=area/cuda.c
libaml_la_SOURCES+=dma/cuda.c
endif

#############################################
Expand Down
Loading