error: the borrowed expression implements the required traits --> masp_primitives/src/transaction/components/sapling.rs:506:29 | 506 | let cv = read_point(&mut reader, "cv")?; | ^^^^^^^^^^^ help: change this to: `reader` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`

casting to the same type is unnecessary (`u64` -> `u64`): masp_primitives/src/transaction/components/sapling/builder.rs#L867

error: casting to the same type is unnecessary (`u64` -> `u64`) --> masp_primitives/src/transaction/components/sapling/builder.rs:867:41 | 867 | arb_positive_note_value(MAX_MONEY as u64 / 10000).prop_flat_map(arb_note), | ^^^^^^^^^^^^^^^^ help: try: `MAX_MONEY` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`i128` -> `i128`): masp_primitives/src/transaction/components/amount.rs#L648

error: casting to the same type is unnecessary (`i128` -> `i128`) --> masp_primitives/src/transaction/components/amount.rs:648:45 | 648 | ValueSum::from_pair(asset_type, amt as i128).unwrap() | ^^^^^^^^^^^ help: try: `amt` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): masp_primitives/src/sapling.rs#L770

error: casting to the same type is unnecessary (`u64` -> `u64`) --> masp_primitives/src/sapling.rs:770:41 | 770 | value in 1u64..=(min(bound, MAX_MONEY as u64)) | ^^^^^^^^^^^^^^^^ help: try: `MAX_MONEY` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): masp_primitives/src/sapling.rs#L762

error: casting to the same type is unnecessary (`u64` -> `u64`) --> masp_primitives/src/sapling.rs:762:49 | 762 | pub fn arb_note_value()(value in 0u64..=MAX_MONEY as u64) -> NoteValue { | ^^^^^^^^^^^^^^^^ help: try: `MAX_MONEY` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast

casting to the same type is unnecessary (`u64` -> `u64`): masp_primitives/src/sapling.rs#L541

error: casting to the same type is unnecessary (`u64` -> `u64`) --> masp_primitives/src/sapling.rs:541:21 | 541 | if value <= MAX_MONEY as u64 { | ^^^^^^^^^^^^^^^^ help: try: `MAX_MONEY` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `-D clippy::unnecessary-cast` implied by `-D warnings`

the following explicit lifetimes could be elided: 'a: masp_primitives/src/sapling/redjubjub.rs#L218

error: the following explicit lifetimes could be elided: 'a --> masp_primitives/src/sapling/redjubjub.rs:218:1 | 218 | / pub fn batch_verify<'a, R: RngCore>( 219 | | mut rng: &mut R, 220 | | batch: &[BatchEntry<'a>], 221 | | p_g: SubgroupPoint, 222 | | ) -> bool { | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `-D clippy::needless-lifetimes` implied by `-D warnings` help: elide the lifetimes | 218 ~ pub fn batch_verify<R: RngCore>( 219 | mut rng: &mut R, 220 ~ batch: &[BatchEntry<'_>], |

useless conversion to the same type: `std::ops::Range<u8>`: masp_primitives/src/merkle_tree.rs#L305

error: useless conversion to the same type: `std::ops::Range<u8>` --> masp_primitives/src/merkle_tree.rs:305:26 | 305 | parents: (1..DEPTH) | __________________________^ 306 | | .into_iter() | |________________________________^ help: consider removing `.into_iter()`: `(1..DEPTH)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings`

this `impl` can be derived: masp_primitives/src/memo.rs#L176

error: this `impl` can be derived --> masp_primitives/src/memo.rs:176:1 | 176 | / impl Default for Memo { 177 | | fn default() -> Self { 178 | | Memo::Empty 179 | | } 180 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `-D clippy::derivable-impls` implied by `-D warnings` = help: remove the manual implementation... help: ...and instead derive it... | 150 + #[derive(Default)] 151 | pub enum Memo { | help: ...and mark the default variant | 152 ~ #[default] 153 ~ Empty, |

lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq`: masp_primitives/src/lib.rs#L16

error: lint `clippy::derive_hash_xor_eq` has been renamed to `clippy::derived_hash_with_manual_eq` --> masp_primitives/src/lib.rs:16:10 | 16 | #![allow(clippy::derive_hash_xor_eq)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `clippy::derived_hash_with_manual_eq` | = note: `-D renamed-and-removed-lints` implied by `-D warnings`

Lint

Clippy had exited with the 101 exit code

the borrowed expression implements the required traits: masp_primitives/src/transaction/components/sapling.rs#L506