Skip to content

Commit

Permalink
Removed the BuildParams::proof_generation_key function because its su…
Browse files Browse the repository at this point in the history
…perceded by the ExtendedKey trait. Removed BuildParams::auth_sig because signatures can be modified after the build using the MapAuth trait.
  • Loading branch information
murisi committed Sep 18, 2024
1 parent f2b0cae commit a35f73b
Showing 1 changed file with 0 additions and 26 deletions.
26 changes: 0 additions & 26 deletions masp_primitives/src/transaction/components/sapling/builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,6 @@ pub trait BuildParams {
fn spend_rcv(&mut self, i: usize) -> jubjub::Fr;
/// Get the spend authorization randomizer for the ith spend description
fn spend_alpha(&mut self, i: usize) -> jubjub::Fr;
/// Get the authorization signature for the ith spend description
fn auth_sig(&mut self, i: usize) -> Option<Signature>;
/// The proof generation key for the ith spend description
fn proof_generation_key(&mut self, i: usize) -> Option<ProofGenerationKey>;
/// Get the commitment value randomness for the ith convert description
fn convert_rcv(&mut self, i: usize) -> jubjub::Fr;
/// Get the commitment value randomness for the ith output description
Expand All @@ -74,12 +70,6 @@ impl<B: BuildParams + ?Sized> BuildParams for Box<B> {
fn spend_alpha(&mut self, i: usize) -> jubjub::Fr {
(**self).spend_alpha(i)
}
fn auth_sig(&mut self, i: usize) -> Option<Signature> {
(**self).auth_sig(i)
}
fn proof_generation_key(&mut self, i: usize) -> Option<ProofGenerationKey> {
(**self).proof_generation_key(i)
}
fn convert_rcv(&mut self, i: usize) -> jubjub::Fr {
(**self).convert_rcv(i)
}
Expand Down Expand Up @@ -292,14 +282,6 @@ impl BuildParams for StoredBuildParams {
self.spend_params[i].alpha
}

fn auth_sig(&mut self, i: usize) -> Option<Signature> {
self.spend_params[i].auth_sig
}

fn proof_generation_key(&mut self, i: usize) -> Option<ProofGenerationKey> {
self.spend_params[i].proof_generation_key.clone()
}

fn convert_rcv(&mut self, i: usize) -> jubjub::Fr {
self.convert_params[i].rcv
}
Expand Down Expand Up @@ -402,14 +384,6 @@ impl<R: CryptoRng + RngCore> BuildParams for RngBuildParams<R> {
self.spend_params(i).alpha
}

fn auth_sig(&mut self, i: usize) -> Option<Signature> {
self.spend_params(i).auth_sig
}

fn proof_generation_key(&mut self, i: usize) -> Option<ProofGenerationKey> {
self.spend_params(i).proof_generation_key.clone()
}

fn convert_rcv(&mut self, i: usize) -> jubjub::Fr {
self.convert_params(i).rcv
}
Expand Down

0 comments on commit a35f73b

Please sign in to comment.