[WIP] update note encryption #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
joe/update_masp_note_encryption
branch
from
aae4d02
to
c5d822f
Compare
ghost
force-pushed
the
joe/update_masp_note_encryption
branch
from
c5d822f
to
e129696
Compare
ghost
changed the title
|
This PR is left intentionally unfinished for some future time (perhaps never) depending on whether the API changes affect future development. If so, then this PR can be a starting point, otherwise, it does not appear to have much value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
masp_note_encryptionto latestzcash_note_encryptionNote the API has changed, which uses
PaymentAddressas a field ofNoterather thang_dandpk_d. This means there is a functional change: BorshSerialize/BorshDeserialize has to (de)serialize the 11 byte diversifier instead of the 32 byteg_d. This seems like a better idea anyway.