Guarantee success in ValueSum::from_pair. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
murisi
force-pushed
the
murisi/guarantee-value-sum
branch
from
927948e
to
9119d6e
Compare
grarco
approved these changes
May 7, 2024
batconjurer
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ValueSum::from_pairreturn aValueSuminstead of aResult<ValueSum, _>. This makes this frequently used function easier to use. Given thatResult::Okwas always returned before, it's safe to now remove all theResult::unwraps andResult::map_errs that surrounded eachValueSum::from_paircall.