Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the internals of ValueSum private #80

Merged
merged 2 commits into from
May 8, 2024
Merged

Make the internals of ValueSum private #80

merged 2 commits into from
May 8, 2024

Conversation

batconjurer
Copy link
Member

Make the internals of ValueSum private so we know that invariants of representation are maintained

@batconjurer batconjurer requested a review from murisi May 8, 2024 08:42
murisi
murisi approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure that Namada still compiles nicely with a private BTreeMap. Otherwise, this looks good to me. Thanks!

@batconjurer batconjurer merged commit 95cf327 into main May 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murisi murisi murisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@batconjurer @murisi