Skip to content

Merge branch 'main' into mariari/bump-borsh #452

Merge branch 'main' into mariari/bump-borsh

Merge branch 'main' into mariari/bump-borsh #452

GitHub Actions / Clippy (MSRV) failed Sep 21, 2023 in 0s

Clippy (MSRV)

4 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 4
Warning 0
Note 0
Help 0

Versions

  • rustc 1.70.0 (90c541806 2023-05-31)
  • cargo 1.70.0 (ec8a8a0ca 2023-04-25)
  • clippy 0.1.70 (90c5418 2023-05-31)

Annotations

Check failure on line 488 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `[u8; 43]`

error: useless conversion to the same type: `[u8; 43]`
   --> masp_primitives/src/sapling.rs:488:41
    |
488 |         let res = Self::from_bytes(&mut data.try_into().unwrap());
    |                                         ^^^^^^^^^^^^^^^
    |
    = help: consider removing `.try_into()`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`

Check failure on line 488 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

the function `Self::from_bytes` doesn't need a mutable reference

error: the function `Self::from_bytes` doesn't need a mutable reference
   --> masp_primitives/src/sapling.rs:488:36
    |
488 |         let res = Self::from_bytes(&mut data.try_into().unwrap());
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
    = note: `-D clippy::unnecessary-mut-passed` implied by `-D warnings`

Check failure on line 488 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `[u8; 43]`

error: useless conversion to the same type: `[u8; 43]`
   --> masp_primitives/src/sapling.rs:488:41
    |
488 |         let res = Self::from_bytes(&mut data.try_into().unwrap());
    |                                         ^^^^^^^^^^^^^^^
    |
    = help: consider removing `.try_into()`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
    = note: `-D clippy::useless-conversion` implied by `-D warnings`

Check failure on line 488 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

the function `Self::from_bytes` doesn't need a mutable reference

error: the function `Self::from_bytes` doesn't need a mutable reference
   --> masp_primitives/src/sapling.rs:488:36
    |
488 |         let res = Self::from_bytes(&mut data.try_into().unwrap());
    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
    = note: `-D clippy::unnecessary-mut-passed` implied by `-D warnings`