Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP - feat/1078: Extension: Permission improvements #1142

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

WIP - feat/1078: Extension: Permission improvements #1142

wants to merge 6 commits into from

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Sep 26, 2024 •
edited
Loading

Resolves #1078

  • Establish new permissions model storage for approving features per chain per domain
  • Prompt user to enable signing for chain ID in domain approval
  • When chain ID changes in interface (such as pointing to a different indexer) prompt for approval to enable signing for that chain
  • Update unit tests for Approvals service

Notes

  • To make all of this possible, we need to pass chainId to any extension connection functionality - in Integrations, this will be optional, but runtime-checked in Namada integration)

@jurevans jurevans self-assigned this Sep 26, 2024
@jurevans jurevans force-pushed the feat/1078-approve-chain-id branch 3 times, most recently from c49fa7a to 22ba6bf Compare September 30, 2024 10:38
@jurevans jurevans changed the title WIP: feat/1078 - Extension: Chain ID approval WIP - feat/1078: Extension: Chain ID approval Sep 30, 2024
@jurevans jurevans force-pushed the feat/1078-approve-chain-id branch 3 times, most recently from 82488eb to e0cc486 Compare October 4, 2024 17:23
@jurevans jurevans force-pushed the feat/1078-approve-chain-id branch 6 times, most recently from 5997a9f to 436ce47 Compare October 24, 2024 15:05
@jurevans jurevans changed the title WIP - feat/1078: Extension: Chain ID approval WIP - feat/1078: Extension: Permission improvements Oct 24, 2024
@jurevans jurevans force-pushed the feat/1078-approve-chain-id branch 4 times, most recently from 33736ad to dfb6ebc Compare October 29, 2024 12:24
@jurevans jurevans force-pushed the feat/1078-approve-chain-id branch 4 times, most recently from f6383fd to 7524509 Compare November 6, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jurevans jurevans

Labels
App: Extension
Projects
None yet
Milestone
Keychain (v0.3.3) / SDK (v0.11.0) rel...
Development

Successfully merging this pull request may close these issues.

Extension: Allow interface to specify chain ID when connecting, update when approved
2 participants
@jurevans @brentstone