Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: feat/1206 - SDK: Adding events to shielded sync #1212

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP: feat/1206 - SDK: Adding events to shielded sync #1212

wants to merge 3 commits into from

Conversation

jurevans
Copy link
Collaborator

@jurevans jurevans commented Oct 25, 2024 •
edited by mateuszjasiuk
Loading

Resolves #1206
todo

  • export progress types - scanned/fetched/applied
  • remove "// total is 0 so we do not get NaN"
  • fix circular dependency in balance/services.ts
  • export progress bar status
  • add event payload types
  • EventDispatcher scope type as enum?
  • check if options.bubbles(true); etc is needed

@jurevans jurevans force-pushed the feat/1206-shielded-sync-events branch 4 times, most recently from 2a72925 to c318d65 Compare October 31, 2024 16:45
@mateuszjasiuk mateuszjasiuk self-assigned this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mateuszjasiuk mateuszjasiuk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: Shielded-Sync should broadcast events
2 participants
@jurevans @mateuszjasiuk