-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable IBC withdrawals for all tokens #1243
Conversation
5a4c920
to
cbf960c
Compare
a54e752
to
bf36c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -0,0 +1,13 @@ | |||
export const txKinds = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to discuss how we're going to organize the types in the codebase. One advantage of having them in a root folder is that is easy to find, import, and maintain. Do you think we should break the types in different files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually did this just because I needed a const
and I couldn't do that in types.d.ts
. Now that your PR changes it to types.ts
, we could still use that but I'll leave that until we discuss how to handle it.
bf36c9b
to
f073cdc
Compare
f073cdc
to
14106eb
Compare
This PR allows IBC withdrawals for all assets, instead of just NAM.
There is still zero indication to the user about whether the transaction failed or succeeded, but for testing this information should be displayed in the console.
Changed
Added
Fixed