Namadillo: Transaction history list #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
reviewed
Nov 13, 2024
There was a problem hiding this comment.
This looks great!
I left quite a few comments, but the main thing I think is that we could simplify a lot by using the information we already have about a tx instead of parsing it from the RPC response, or even dropping it altogether if the information is not needed (e.g. possibly resultTxHash).
But I think this looks really good, and just waiting for a couple of fixes where things aren't working for approval.
pedrorezende
force-pushed
the
feat/tx-list-history
branch
2 times, most recently
from
ffd9e26
to
480e996
Compare
euharrison
approved these changes
Nov 14, 2024
| tx as IbcTransferTransactionData, | ||
| changeTransaction | ||
| ); | ||
| } |
There was a problem hiding this comment.
we need to return something for queryFn other than undefined. Otherwise we got this error
…instead of Asset object
pedrorezende
force-pushed
the
feat/tx-list-history
branch
from
480e996
to
2795790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a transaction history page and all the necessary structure behind it.
It also creates a confirmation screen and its implementation with IBC Transfers.
Added
useTransactionWatcherhook polls the rpc every x seconds to check if the pending transaction has new events / related txsuseTransactionActions: helper hook to interact with the transaction local storage/transaction/:hashand/historyroutesOther Changes
types.d.tswas renamed totypes.tsand all type errors were fixedTokenCurrencynow acceptssymbolinstead of anAssetCloses #1186
Closes #1184
Closes #1199