fix: make publicKey a required field in the TxMsgValue class. #659
Conversation
|
Okay, no wait. This does not match with the SDK. This expects an Option value. Hmm. Is there a way to let the extension know that this is a required field without it panicking/crashing if it's not set? Or an alternative to making it required is to let the extension auto-read the public key from the signer if it's not set (if this is a smart thing to do). Also, because we're halted now, I'm getting a similar panic-result. Is there a way to get these crashes to the frontend and not inside of the extension?
|
|
I'll keep this PR here to keep this open 'as a discussion/issue'. |
Hello! Thank you for your c ontribution! Can you please close this one and open an issue? We will try to refine the "backlog" regularly and discuss potential problems there. Thanks! We should probably add contrib instructions to the README. We just have a lot of things to do atm. |
|
@zenodeapp You need to push a message from the service worker, into the main window, then you'd be able to log the errors in the frontend. However, you'd want to enable that only in dev mode |
Yes I shall! This is probably not a big prio as I didn't realize it was only in development mode. But @phy-chain that sounds like what needs to be done indeed. I'm not sure if it gets handled correctly in production mode either though, I'll test this later. But yes will close this! |
Hi again!
As I was working on #658 I couldn't seem to understand why the transactions weren't resolving. Checking the console of the extension I realized I didn't pass a publicKey value to my
sendIbcTransfercausing the extension to panic! I thus made it a required field in the TxMsgValue class. This way it doesn't even get to the extension when a transaction doesn't contain this.