-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Reduce time when fetching masp #667
base: main
Are you sure you want to change the base?
Conversation
Amazing @pnam1609 ! |
@@ -40,13 +40,16 @@ | |||
"@ledgerhq/hw-transport": "^6.30.0", | |||
"@ledgerhq/hw-transport-webhid": "^6.28.0", | |||
"@ledgerhq/hw-transport-webusb": "^6.28.0", | |||
"@material-ui/core": "^4.12.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that necessary ? It drags an old version babel/runtime with it, which combine are quite huge, and an open door for potentail security issues through babel runtime : GHSA-67hx-6x53-jw92 (just an example)
Would be nice too if we could load a shielded.dat file generated on a node instance for instance (maybe only in dev ?), that way, we can speed up the process of syncing if we already have a synced context via CLI |
Ping me on Discord so we can chat more easily, I want to help ! "phychain" |
@pnam1609 I really appriciate the effort. I think it will be hard to merge this soon. The reason is you worked under some assumptions about how things should work and look like. The proper flow would be:
We plan to create contribution guide soon. This way it will be easier for both you and us to cooperate :) |
Cool, thank you for your hard work. We need it ASAP |
Hi @mateuszjasiuk , Thanks for your response. I hope it's available as soon as possible and i can contribute more for project. |
@pnam1609 Really nice ! I appreciate your comprehensive solution, which outlines a systematic approach to optimize block fetching by implementing block ranges, utilizing Promise pools for parallel processing, and ensuring data integrity through temporary IndexedDB storage. Your solution not only enhances efficiency by reducing fetch times but also provides a robust mechanism for handling interruptions and displaying progress to the user. Awesome valuable contribution. |
Hello,
WDYT? |
Hi @mateuszjasiuk, Thanks for your reponse.
|
feat: use namda sdk 0.32.0 and move old code use old dependency
Issue
Link: Fetching shielded balance via SDK nor extension working
Solution
Image
Note: