-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faucet: Add handling for chains API #685
Open
givingmittal
wants to merge
1
commit into
anoma:main
Choose a base branch
from
givingmittal:givingmittal/faucet-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
import { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can't you just reuse the current api.ts ? |
||
ChallengeResponse, | ||
Data, | ||
ErrorResponse, | ||
ChainsResponse, | ||
} from "./types"; | ||
|
||
enum Endpoint { | ||
ChainsData = "", | ||
} | ||
|
||
export class ChainsAPI { | ||
constructor(protected readonly url: string, protected readonly chainId: string) {} | ||
|
||
/** | ||
* Wrapper for fetch requests to handle ReadableStream response when errors are received from API | ||
* | ||
* @param {string} endpoint | ||
* @param {RequestInit} options | ||
* | ||
* @returns Object | ||
*/ | ||
async request<T = unknown>( | ||
endpoint: string, | ||
options: RequestInit = { method: "GET" } | ||
): Promise<T> { | ||
return await fetch(new URL(`${this.url}${endpoint}`), { | ||
...options, | ||
}) | ||
.then((response) => { | ||
if (response.ok) { | ||
return response.json(); | ||
} | ||
const reader = response?.body?.getReader(); | ||
const errors = reader?.read().then((data): Promise<ErrorResponse> => { | ||
const response = JSON.parse( | ||
new TextDecoder().decode(data.value) | ||
) as ErrorResponse; | ||
// If code 429 is received on any request, rate limiting is blocking | ||
// requests from this this IP, so provide a specific message: | ||
if (response.code === 429) { | ||
response.message = "Too many requests! Try again in one hour."; | ||
} | ||
return Promise.reject(response); | ||
}); | ||
if (!errors) { | ||
throw new Error("Unable to parse error response"); | ||
} | ||
return errors; | ||
}) | ||
.catch((e) => { | ||
console.error(e); | ||
return Promise.reject(e); | ||
}); | ||
} | ||
|
||
/** | ||
* Request faucet settings | ||
* | ||
* @returns Object | ||
*/ | ||
async chainsData(): Promise<ChainsResponse> { | ||
return this.request(Endpoint.ChainsData); | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export * from "./api"; | ||
export * from "./chainsApi"; | ||
export * from "./pow"; | ||
export * from "./types"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to move this
try...catch
block to the separete function. I think that would make code more readable. Also it should help with getting rid off mutations in multiple places. At the moment it's a bit difficult to follow what is going on.