Namadillo: Fees #904
Closed
Namadillo: Fees #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
reviewed
Jul 8, 2024
| @@ -30,7 +30,8 @@ export const fetchMinimumGasPrice = async ( | |||
| ({ token }) => token === nativeToken | |||
| ); | |||
| invariant(!!nativeTokenCost, "Error querying minimum gas price"); | |||
| const asBigNumber = new BigNumber(nativeTokenCost.amount); | |||
| // TODO: this should be removed after indexer error is fixed! | |||
There was a problem hiding this comment.
It looks like this is fixed now.
| className="font-medium" | ||
| forceBalanceDisplay={true} | ||
| amount={gasPrice.data.multipliedBy( | ||
| gasLimits.data[txKind].native.multipliedBy(numberOfTransactions) |
There was a problem hiding this comment.
Will this still be correct in cases where a reveal PK is needed?
There was a problem hiding this comment.
I think I need to review it again after the batch tx PR gets in
There was a problem hiding this comment.
With batch Tx in, RevealPk wasn't considered when calculating fees - it is overestimating though so will work as is (though is incorrect). We still need to determine how fees can be calculated when we have a batch with of Txs, and (currently) at most 2 Tx types in that batch (RevealPK + the type of other Txs). I'm up for taking a look, and we don't necessarily need to address that in this PR!
jurevans
approved these changes
Jul 26, 2024
|
Closing it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back the fees panel with its respective warning