Merge branch 'tiago/fix-tok-bal-query-errs' (#2356)

* origin/tiago/fix-tok-bal-query-errs: Changelog Fix querying error while checking token balance
anoma · Jan 12, 2024 · 196b789 · 196b789
2 parents 2be10f6 + 472a0cd
commit 196b789
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/.changelog/unreleased/bug-fixes/1910-fix-tok-bal-query-errs.md b/.changelog/unreleased/bug-fixes/1910-fix-tok-bal-query-errs.md
@@ -0,0 +1,2 @@
+- Suppress querying errors when a user has no token balance
+  ([\#1910](https://github.com/anoma/namada/issues/1910))
diff --git a/apps/src/lib/client/rpc.rs b/apps/src/lib/client/rpc.rs
@@ -47,7 +47,9 @@ use namada::types::masp::{BalanceOwner, ExtendedViewingKey, PaymentAddress};
 use namada::types::storage::{BlockHeight, BlockResults, Epoch, Key, KeySeg};
 use namada::types::token::{Change, MaspDenom};
 use namada::types::{storage, token};
-use namada_sdk::error::{is_pinned_error, Error, PinnedBalanceError};
+use namada_sdk::error::{
+    is_pinned_error, Error, PinnedBalanceError, QueryError,
+};
 use namada_sdk::masp::{Conversions, MaspAmount, MaspChange};
 use namada_sdk::proof_of_stake::types::ValidatorMetaData;
 use namada_sdk::rpc::{
@@ -338,15 +340,20 @@ pub async fn query_transparent_balance(
                             balance
                         );
                     }
-                    Err(e) => {
-                        display_line!(context.io(), "Querying error: {e}");
+                    Err(namada_sdk::error::Error::Query(
+                        QueryError::NoSuchKey(_),
+                    )) => {
                         display_line!(
                             context.io(),
-                            "No {} balance found for {}",
-                            token_alias,
-                            owner
+                            "No {token_alias} balance found for {owner}",
                         )
                     }
+                    Err(e) => {
+                        display_line!(
+                            context.io(),
+                            "Error querying balance of {token_alias}: {e}"
+                        );
+                    }
                 }
             }
         }