Skip to content

Commit

Permalink
merged V0.18.1
Browse files Browse the repository at this point in the history
  • Loading branch information
mariari committed Jul 6, 2023
2 parents 04e1d9d + fe693cb commit 3e11957
Show file tree
Hide file tree
Showing 78 changed files with 2,028 additions and 1,502 deletions.
2 changes: 2 additions & 0 deletions .changelog/v0.18.1/bug-fixes/1607-fix-tx-malleability.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Fixed bug that allowed transactions to be modified without invalidating
transaction hash ([\#1607](https://github.com/anoma/namada/pull/1607))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Move the content and code of init proposal transactions
into separare section to reduce tx size for hardware wallets
([\#1611](https://github.com/anoma/namada/pull/1611))
2 changes: 2 additions & 0 deletions .changelog/v0.18.1/features/1632-delete-prefix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Storage: Add a function to delete key-vals matching a given prefix.
([\#1632](https://github.com/anoma/namada/pull/1632))
3 changes: 3 additions & 0 deletions .changelog/v0.18.1/improvements/1498-separate-signing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Separate the transaction building, signing, and submission
actions in the SDKs API to enable hardware wallet usage
([\#1498](https://github.com/anoma/namada/pull/1498))
2 changes: 2 additions & 0 deletions .changelog/v0.18.1/improvements/1636-disable-encryption.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Disable encryption when sending transactions
([\#1636](https://github.com/anoma/namada/pull/1636))
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Storage: Ensure that prefix iterator only returns key-
vals in which the prefix key segments are matched fully.
([\#1642](https://github.com/anoma/namada/pull/1642))
1 change: 1 addition & 0 deletions .changelog/v0.18.1/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Namada 0.18.1 is a patch release that addresses transaction format changes and minor ledger storage improvements.
10 changes: 10 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/new_topic.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Describe your changes

## Indicate on which other PRs this topic is based on, if any

## Checklist before merging to `draft`
- [ ] I have checked that the following e2e test are working locally
- `masp_incentives`
- `masp_txs_and_queries`
- `proposal_submission`
- [ ] I have added a changelog
28 changes: 28 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,33 @@
# CHANGELOG

## v0.18.1

Namada 0.18.1 is a patch release that addresses transaction format changes and minor ledger storage improvements.

### BUG FIXES

- Fixed bug that allowed transactions to be modified without invalidating
transaction hash ([\#1607](https://github.com/anoma/namada/pull/1607))
- Move the content and code of init proposal transactions
into separare section to reduce tx size for hardware wallets
([\#1611](https://github.com/anoma/namada/pull/1611))

### FEATURES

- Storage: Add a function to delete key-vals matching a given prefix.
([\#1632](https://github.com/anoma/namada/pull/1632))

### IMPROVEMENTS

- Separate the transaction building, signing, and submission
actions in the SDKs API to enable hardware wallet usage
([\#1498](https://github.com/anoma/namada/pull/1498))
- Disable encryption when sending transactions
([\#1636](https://github.com/anoma/namada/pull/1636))
- Storage: Ensure that prefix iterator only returns key-
vals in which the prefix key segments are matched fully.
([\#1642](https://github.com/anoma/namada/pull/1642))

## v0.18.0

Namada 0.18.0 is a minor release primarily addressing a major change in the token amount representation, the addition of a new validator set category, and other minor improvements to the ledger stability.
Expand Down
24 changes: 12 additions & 12 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ keywords = ["blockchain", "privacy", "crypto", "protocol", "network"]
license = "GPL-3.0"
readme = "README.md"
repository = "https://github.com/anoma/namada"
version = "0.18.0"
version = "0.18.1"

[workspace.dependencies]
ark-bls12-381 = {version = "0.3"}
Expand Down
38 changes: 33 additions & 5 deletions apps/src/bin/namada-client/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
use color_eyre::eyre::{eyre, Report, Result};
use namada::ledger::eth_bridge::bridge_pool;
use namada::ledger::rpc::wait_until_node_is_synched;
use namada::ledger::{signing, tx as sdk_tx};
use namada::types::control_flow::ProceedOrElse;
use namada_apps::cli;
use namada_apps::cli::args::CliToSdk;
Expand Down Expand Up @@ -112,7 +113,7 @@ pub async fn main() -> Result<()> {
.proceed_or_else(error)?;
let args = args.to_sdk(&mut ctx);
tx::submit_init_validator::<HttpClient>(&client, ctx, args)
.await;
.await?;
}
Sub::TxInitProposal(TxInitProposal(mut args)) => {
let client = HttpClient::new(utils::take_config_address(
Expand Down Expand Up @@ -186,6 +187,20 @@ pub async fn main() -> Result<()> {
tx::submit_withdraw::<HttpClient>(&client, ctx, args)
.await?;
}
Sub::TxCommissionRateChange(TxCommissionRateChange(
mut args,
)) => {
let client = HttpClient::new(utils::take_config_address(
&mut args.tx.ledger_address,
))
.unwrap();
wait_until_node_is_synched(&client).await;
let args = args.to_sdk(&mut ctx);
tx::submit_validator_commission_change::<HttpClient>(
&client, ctx, args,
)
.await?;
}
// Eth bridge
Sub::AddToEthBridgePool(args) => {
let mut args = args.0;
Expand All @@ -197,14 +212,27 @@ pub async fn main() -> Result<()> {
.await
.proceed_or_else(error)?;
let args = args.to_sdk(&mut ctx);
let chain_id = ctx.config.ledger.chain_id.clone();
bridge_pool::add_to_eth_bridge_pool(
let tx_args = args.tx.clone();
let (mut tx, addr, pk) = bridge_pool::build_bridge_pool_tx(
&client,
&mut ctx.wallet,
chain_id,
args,
)
.await;
.await
.unwrap();
tx::submit_reveal_aux(
&client,
&mut ctx,
&tx_args,
addr,
pk.clone(),
&mut tx,
)
.await?;
signing::sign_tx(&mut ctx.wallet, &mut tx, &tx_args, &pk)
.await?;
sdk_tx::process_tx(&client, &mut ctx.wallet, &tx_args, tx)
.await?;
}
// Ledger queries
Sub::QueryEpoch(QueryEpoch(mut args)) => {
Expand Down
Loading

0 comments on commit 3e11957

Please sign in to comment.