fixup! vp/multitoken: refactor maps and sets usage

anoma · Jan 25, 2024 · 52b9943 · 52b9943
1 parent bcf4d5d
commit 52b9943
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/crates/namada/src/ledger/native_vp/multitoken.rs b/crates/namada/src/ledger/native_vp/multitoken.rs
@@ -63,27 +63,29 @@ where
                     Some(diff) => {
                         let change =
                             inc_changes.entry(token.clone()).or_default();
-                        change.checked_add(diff).ok_or_else(|| {
-                            Error::NativeVpError(
-                                native_vp::Error::SimpleMessage(
-                                    "Overflowed in balance check",
-                                ),
-                            )
-                        })?;
+                        *change =
+                            change.checked_add(diff).ok_or_else(|| {
+                                Error::NativeVpError(
+                                    native_vp::Error::SimpleMessage(
+                                        "Overflowed in balance check",
+                                    ),
+                                )
+                            })?;
                     }
                     None => {
                         let diff = pre
                             .checked_sub(post)
                             .expect("Underflow shouldn't happen here");
                         let change =
                             dec_changes.entry(token.clone()).or_default();
-                        change.checked_add(diff).ok_or_else(|| {
-                            Error::NativeVpError(
-                                native_vp::Error::SimpleMessage(
-                                    "Overflowed in balance check",
-                                ),
-                            )
-                        })?;
+                        *change =
+                            change.checked_add(diff).ok_or_else(|| {
+                                Error::NativeVpError(
+                                    native_vp::Error::SimpleMessage(
+                                        "Overflowed in balance check",
+                                    ),
+                                )
+                            })?;
                     }
                 }
             } else if let Some(token) = is_any_minted_balance_key(key) {
@@ -92,7 +94,7 @@ where
                 match post.checked_sub(pre) {
                     Some(diff) => {
                         let mint = inc_mints.entry(token.clone()).or_default();
-                        mint.checked_add(diff).ok_or_else(|| {
+                        *mint = mint.checked_add(diff).ok_or_else(|| {
                             Error::NativeVpError(
                                 native_vp::Error::SimpleMessage(
                                     "Overflowed in balance check",
@@ -105,7 +107,7 @@ where
                             .checked_sub(post)
                             .expect("Underflow shouldn't happen here");
                         let mint = dec_mints.entry(token.clone()).or_default();
-                        mint.checked_add(diff).ok_or_else(|| {
+                        *mint = mint.checked_add(diff).ok_or_else(|| {
                             Error::NativeVpError(
                                 native_vp::Error::SimpleMessage(
                                     "Overflowed in balance check",