Merge branch 'tomas/leak-hunt' (#3529)

* tomas/leak-hunt:
  changelog: add #3529
  workaround wasmer store segfault by keeping it in cache
  use a weak Rc in wasm memory to avoid leaking it

.changelog/unreleased/bug-fixes/3529-leak-workaround.md

@@ -0,0 +1,2 @@
+- Workaround a leak in wasmer store.
+  ([\#3529](https://github.com/anoma/namada/pull/3529))

Cargo.toml

@@ -191,10 +191,12 @@ tracing-log = "0.2.0"
 tracing-subscriber = {version = "0.3.7", default-features = false, features = ["env-filter", "fmt"]}
 wasmparser = "0.107.0"
 wasm-instrument = {version = "0.4.0", features = ["sign_ext"]}
-wasmer = "4.3.1"
-wasmer-cache = "4.3.1"
-wasmer-compiler-singlepass = "4.3.1"
-wasmer-vm = "4.3.1"
+wasmer = "4.3.5"
+wasmer-cache = "4.3.5"
+wasmer-compiler = "4.3.5"
+wasmer-compiler-singlepass = "4.3.5"
+wasmer-types = "4.3.5"
+wasmer-vm = "4.3.5"
 winapi = "0.3.9"
 yansi = "0.5.1"
 zeroize = { version = "1.5.5", features = ["zeroize_derive"] }

crates/namada/Cargo.toml

@@ -169,3 +169,5 @@ tempfile.workspace = true
 test-log.workspace = true
 tokio = { workspace = true, features = ["rt", "macros"] }
 tracing-subscriber.workspace = true
+wasmer-compiler = { workspace = true }
+wasmer-types = { workspace = true }

crates/namada/src/vm/host_env.rs

@@ -2422,21 +2422,23 @@ pub mod testing {
         tx_index: &TxIndex,
         result_buffer: &mut Option<Vec<u8>>,
         yielded_value: &mut Option<Vec<u8>>,
+        store: Rc<RefCell<wasmer::Store>>,
         #[cfg(feature = "wasm-runtime")] vp_wasm_cache: &mut VpCache<CA>,
         #[cfg(feature = "wasm-runtime")] tx_wasm_cache: &mut TxCache<CA>,
     ) -> TxVmEnv<WasmMemory, <S as StateRead>::D, <S as StateRead>::H, CA>
     where
         S: State,
         CA: WasmCacheAccess,
     {
-        let mut store = crate::vm::wasm::compilation_cache::common::store();
-
-        let wasm_memory =
-            crate::vm::wasm::memory::prepare_tx_memory(&mut store).unwrap();
+        let wasm_memory = {
+            let mut borrowed_store = store.borrow_mut();
+            crate::vm::wasm::memory::prepare_tx_memory(&mut *borrowed_store)
+                .unwrap()
+        };
 
         let (write_log, in_mem, db) = state.split_borrow();
         let mut env = TxVmEnv::new(
-            WasmMemory::new(Rc::new(RefCell::new(store))),
+            WasmMemory::new(Rc::downgrade(&store)),
             write_log,
             in_mem,
             db,