Merge pull request #2454 from anoma/tomas/fix-tx-redelegate-input

test/tx_redelegate: prevent redelegation delegator from being validator
anoma · Jan 30, 2024 · 7c0c2fe · 7c0c2fe
2 parents bfba3db + cd43f1a
commit 7c0c2fe
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/wasm/wasm_source/src/tx_redelegate.rs b/wasm/wasm_source/src/tx_redelegate.rs
@@ -403,9 +403,15 @@ mod tests {
             token::testing::arb_amount_non_zero_ceiled(max_amount),
         )
             .prop_filter_map(
-                "Src and dest validator must not be the same",
+                "Src and dest validator must not be the same and owner must \
+                 not be a validator",
                 |(src_validator, dest_validator, owner, amount)| {
-                    if src_validator == dest_validator {
+                    let is_owner_validator = matches!(
+                        &owner,
+                        Address::Established(owner)
+                        if owner == &src_validator || owner == &dest_validator
+                    );
+                    if is_owner_validator || src_validator == dest_validator {
                         None
                     } else {
                         let src_validator = Address::Established(src_validator);