Skip to content

Commit

Permalink
fixup! Merge branch 'yuji/ibc_shielded_transfer' (#2322)
Browse files Browse the repository at this point in the history
  • Loading branch information
brentstone committed Dec 29, 2023
1 parent b7a92ca commit 830de2e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
4 changes: 3 additions & 1 deletion apps/src/lib/client/tx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -967,7 +967,7 @@ where
&args.source.effective_address(),
)
.await?;
let (mut tx, signing_data) = args.build(namada).await?;
let (mut tx, signing_data, _) = args.build(namada).await?;

if args.tx.dump_tx {
tx::dump_tx(namada.io(), &args.tx, tx);
Expand All @@ -976,6 +976,8 @@ where

namada.submit(tx, &args.tx).await?;
}
// NOTE that the tx could fail when its submission epoch doesn't match
// construction epoch

Ok(())
}
Expand Down
2 changes: 1 addition & 1 deletion core/src/types/ibc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ use crate::ibc::apps::transfer::types::{Memo, PrefixedDenom, TracePath};
use crate::ibc::core::handler::types::events::{
Error as IbcEventError, IbcEvent as RawIbcEvent,
};
pub use crate::ledger::ibc::storage::is_ibc_key;
use crate::ibc::primitives::proto::Protobuf;
pub use crate::ledger::ibc::storage::is_ibc_key;
use crate::tendermint::abci::Event as AbciEvent;
use crate::types::masp::PaymentAddress;
use crate::types::token::Transfer;
Expand Down
3 changes: 2 additions & 1 deletion sdk/src/args.rs
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,8 @@ impl TxIbcTransfer {
pub async fn build(
&self,
context: &impl Namada,
) -> crate::error::Result<(crate::proto::Tx, SigningTxData)> {
) -> crate::error::Result<(crate::proto::Tx, SigningTxData, Option<Epoch>)>
{
tx::build_ibc_transfer(context, self).await
}
}
Expand Down

0 comments on commit 830de2e

Please sign in to comment.