Merge remote-tracking branch 'origin/main' into fraccaman/improve-tx-…

…dump

* origin/main: (191 commits)
  ci: use custom runner for docs step
  fix: better checkout settings, fix sccache wrapper
  changelog: add #3694
  fix wasm dir during join-network
  Changelog #3689
  Minor fixes to governance cli/msgs
  fix: use current epoch
  Changelog
  Add script boot localnet with two genesis validators
  Updates expected msg in wallet e2e test
  Changelog #3681
  Two attempts for decryption password
  Removes comments
  Prompts the key that we are trying to decrypt
  Terminates client if decryption of signing key fails
  Propagates error in sdk if decryption of signing key fails
  Removes FIXME comment
  Add fullnode support
  added changelog
  token: fix transfer to self
  make build: exclude fuzz targets
  replace context with client
  Changelog #3676
  Removes test step from wasm for test Makefile
  Removes dev dependencies from wasm tests
  Amend comment in genesis sign txs
  Changelog #3669
  Updates help message of `--gas-limit`
  Refactors `dispatch_inner_txs`
  Adds masp fee payment integration test
  Improves safety of masp txs events
  fix for clippy
  is_apple_silicon
  fixup! ci: add job checking for cargo docs
  README: update docs section
  fix rustdoc issues
  ci: do not run changelog check on rc branches
  ci: increase integration tests timeout
  ci: add job checking for cargo docs
  Namada 0.43.0
  generate key
  changelog: add #3445
  fuzz: add txs_wasm_run
  fuzz: add txs_finalize_block target
  add conditional fuzzing sig acceptance at lower level
  fuzz: add txs_process_proposal
  fuzz: add README.md
  token: avoid trying to read denom when fuzzing
  prepare_proposal: make tx fee checks pass for fuzzing
  fuzz: add txs_prepare_proposal
  fuzz: use a shorter target name
  fix clippy
  tx: prevent overflow in arbitrary masp builder
  fuzz_txs_mempool: rm unused import
  impl Arbitrary for MaspBuilder to derive tx sections
  use updated jubjub that prevents invalid arb ExtendedPoint
  fuzz_txs_mempool: catch panics in serialization
  fuzz_txs_mempool: use non-panicking tx serialization method
  tx: add non-panicking serialization method
  tx: add arbitrary masp tx section
  make/fuzz-txs-mempool: run with `--dev` to avoid OOM
  shell/mempool: skip chain ID check for fuzzing
  tx: fix manual impl Arbitrary for Section
  core/key: fix arbitrary impls
  fuzz_txs_mempool: re-use TestShell between runs
  fuzz: set dev opt-level = 3
  node/init_chain: no wasm pre-compile for fuzzing
  Makefile: add `cargo-fuzz` dep and `fuzz-txs-mempool` recipe
  fuzz mempool with arb txs
  tx: impl Arbitrary for Tx
  init a fuzz target with cargo-fuzz
  fixup! test/e2e/ledger: add test-genesis `--check-can-sign` args
  Improves failures handling in `try_masp_fee_payment`
  Matches masp ref order in protocol with that of the masp vp
  changelog: add #3660
  test/e2e/ledger: add test-genesis `--check-can-sign` args
  cli: added `--check-can-sign` arg to `namadan utils test-genesis`
  add changelog
  rm accidentally revived files
  test/e2e/ledger_tests: add localnet genesis test using `utils test-genesis`
  fix to check the existing addr
  fix default refund target
  fix tests
  add shielded mode to transfer context
  change to transparent addr
  Added changelog
  Fixed bug in creating BenchShieldedContext
  Changelog for #3655
  Optimize building chain ctx
  node/utils/test-genesis: remove unnecessary broadcaster task
  Added tests that birthdays work correctly with shielded sync
  changelog: add #3652
  cli/client: fix clippy
  cli/node: don't load ctx for node utils
  Added dated keys to shielded sync args
  Removed birthday logic from payment address generation
  Moved type alias to a more logical location
  Changelog #3626
  Changes gaia e2e tests to use masp internal address instead of payment addresses for ibc-shielding
  Reverts previous changes
  ...

.changelog/unreleased/bug-fixes/3620-ibc-refund-transparent.md

@@ -0,0 +1,2 @@
+- Support only a transparent address as a refund target of IBC shielding
+  transfer ([\#3620](https://github.com/anoma/namada/issues/3620))

.changelog/unreleased/bug-fixes/3675-improve-init-proposal-validation.md

@@ -0,0 +1,2 @@
+- Make transfers with same source and destion a no-op.
+  ([\#3675](https://github.com/anoma/namada/pull/3675))

.changelog/unreleased/bug-fixes/3694-fix-join-network-wasm-dir.md

@@ -0,0 +1,2 @@
+- Fix path to compiled WASMs that's validated during join-network.
+  ([\#3694](https://github.com/anoma/namada/pull/3694))

.changelog/unreleased/improvements/3669-fix-masp-ident.md

@@ -0,0 +1,2 @@
+- Improved the consistency and safety of MASP events construction in protocol.
+  ([\#3669](https://github.com/anoma/namada/pull/3669))

.changelog/unreleased/improvements/3676-fix-wasm-test-deps.md

@@ -0,0 +1,2 @@
+- Removed the dev dependencies of wasm-for-tests.
+  ([\#3676](https://github.com/anoma/namada/pull/3676))

.changelog/unreleased/improvements/3681-client-tx-signature.md

@@ -0,0 +1,2 @@
+- Improved the user experience of the secret key decryption process.
+  ([\#3681](https://github.com/anoma/namada/pull/3681))

.changelog/unreleased/improvements/3689-misc-gov-fixes.md

@@ -0,0 +1,2 @@
+- Improved some governance messages and cli commands arguments.
+  ([\#3689](https://github.com/anoma/namada/pull/3689))

.changelog/unreleased/testing/3626-ibc-replace-payment-address.md

@@ -0,0 +1,3 @@
+- Updated the gaia e2e tests to use the MASP internal address instead of
+  the payment address as the receiver of an IBC shielding transaction.
+  ([\#3626](https://github.com/anoma/namada/pull/3626))

.changelog/unreleased/testing/3680-gen-localnet-fullnodes.md

@@ -0,0 +1,4 @@
+- Augment the functionality of `gen_localnet.py` with the ability
+  to generate full node base directories. Moreover, add a new script
+  to boot up a localnet with two genesis validators or a full node.
+  ([\#3680](https://github.com/anoma/namada/pull/3680))

.changelog/v0.43.0/SDK/3578-masp-ss-client-phase-3.md

@@ -0,0 +1,2 @@
+- Parallelize the shielded sync implementation in Namada.
+  ([\#3578](https://github.com/anoma/namada/pull/3578))

.changelog/v0.43.0/bug-fixes/3645-implicit-addr-balances-toml-fix.md

@@ -0,0 +1,3 @@
+- Fix genesis bonds from implicit accounts. Now, only addresses
+  of the form `tnam1...` are supported in `balances.toml`.
+  ([\#3645](https://github.com/anoma/namada/pull/3645))

.changelog/v0.43.0/features/3653-masp-key-birthdays.md

@@ -0,0 +1,4 @@
+ - Partially addresses Issue [\#2900](https://github.com/anoma/namada/issues/2900). Viewing and spending keys can now
+   be given birthdays in the form of block heights which are loaded into 
+   shielded sync. Shielded sync will not try to decrypt a block before a 
+   keys birthday with said key. ([\#3653](https://github.com/anoma/namada/pull/3653))

.changelog/v0.43.0/features/3660-check-pre-genesis-signing.md

@@ -0,0 +1,5 @@
+- The command `namadan utils test-genesis` now accepts `--check-can-sign`
+  multi-arg that can be used with genesis addresses and/or public keys to
+  verify that a pre-genesis wallet in the base directory is able to sign
+  with the keys associated with the addresses or with the keys themselves.
+  ([\#3660](https://github.com/anoma/namada/pull/3660))

.changelog/v0.43.0/improvements/3615-no-parallel-gas.md

@@ -0,0 +1,2 @@
+- Removed parallel gas accounting.
+  ([\#3615](https://github.com/anoma/namada/pull/3615))

.changelog/v0.43.0/improvements/3629-improve-init-proposal-validation.md

@@ -0,0 +1,2 @@
+- Improve governance client side validation.
+  ([\#3629](https://github.com/anoma/namada/pull/3629))

.changelog/v0.43.0/improvements/3632-check-masp-action.md

@@ -0,0 +1,2 @@
+- Masp vp and protocol now ensure that a transaction can push at most one MASP
+  action. ([\#3632](https://github.com/anoma/namada/pull/3632))

.changelog/v0.43.0/improvements/3652-ctxless-node-utils.md

@@ -0,0 +1,2 @@
+- Do not load context for `namadan utils test-genesis` command.
+  ([\#3652](https://github.com/anoma/namada/pull/3652))

.changelog/v0.43.0/improvements/3655-speed-up-ctx-build.md

@@ -0,0 +1,5 @@
+- Speeds up client commands on networks with massive balances.toml
+  files. Previously, to retrieve the native token of some network,
+  we had to parse these giant files. Now, we only parse the
+  necessary genesis toml files required to retrieve the native token.
+  ([\#3655](https://github.com/anoma/namada/pull/3655))

.changelog/v0.43.0/summary.md

@@ -0,0 +1 @@
+Namada 0.43.0 is a minor relasing improving shielded sync and addressing some pre-genesis flow issues.

.changelog/v0.43.0/testing/3445-fuzz-tx.md

@@ -0,0 +1,2 @@
+- Added fuzz testing targets for txs in mempool, block proposals and finalize
+  block. ([\#3445](https://github.com/anoma/namada/pull/3445))

.changelog/v0.43.0/testing/3535-ibc-client-upgrade-test.md

@@ -0,0 +1,2 @@
+- Add IBC client upgrade test
+  ([\#3535](https://github.com/anoma/namada/issues/3535))

.github/workflows/ci.yml

@@ -35,8 +35,8 @@ env:
 jobs:
   changelog:
     runs-on: [ubuntu-latest]
-    if: github.event_name == 'pull_request_target' && github.event.pull_request.draft == false
-    timeout-minutes: 15
+    if: github.event_name == 'pull_request_target' && github.event.pull_request.draft == false && !contains(github.ref, '-rc')
+    timeout-minutes: 5
 
     steps:
       - name: Checkout repo
@@ -54,6 +54,46 @@ jobs:
         run: bash .github/workflows/scripts/check-changelog.sh
         env:
           SHA: ${{ github.event.pull_request.head.sha }}
+
+  rust-docs:
+    container: 
+      image: ghcr.io/heliaxdev/namada-ci:namada-main
+    runs-on: [self-hosted, 4vcpu-8ram-ubuntu22-namada-x86]
+    timeout-minutes: 20
+
+    steps:
+      - name: Checkout repo
+        uses: actions/checkout@v4
+        if: ${{ github.event_name != 'pull_request_target' }}
+      - name: Checkout PR
+        uses: actions/checkout@v4
+        if: ${{ github.event_name == 'pull_request_target' }}
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+      - name: Configure AWS 
+        uses: aws-actions/configure-aws-credentials@v4
+        with:
+          aws-region: ${{ env.AWS_REGION }}
+          role-to-assume: ${{ secrets.AWS_ROLE }}
+      - name: Cache cargo
+        id: cache
+        uses: runs-on/cache@v4
+        env:
+          RUNS_ON_S3_BUCKET_CACHE: ${{ env.CACHE_BUCKET }}
+        with:
+          path: /usr/local/cargo
+          key: /cache/${{ runner.os }}-${{ github.job }}-${{ hashFiles('**/Cargo.lock') }}
+      - name: Start sccache server
+        id: sccache
+        run: sccache --start-server
+      - name: Build docs
+        run: make build-doc
+      - name: Clean cargo cache
+        if: steps.cache.outputs.cache-hit != 'true'
+        run: cargo cache --autoclean-expensive
+      - name: Stop sccache
+        if: always() && steps.sccache.conclusion == 'success'
+        run: sccache --stop-server || true
 
   lints:
     container: 
@@ -309,7 +349,7 @@ jobs:
     runs-on: [self-hosted, 8vcpu-16ram-ubuntu22-namada-x86]
     container: 
       image: ghcr.io/heliaxdev/namada-ci:namada-main
-    timeout-minutes: 15
+    timeout-minutes: 20
     needs: [build-wasm]
 
     steps:

.github/workflows/scripts/e2e.json

@@ -6,6 +6,7 @@
     "e2e::ibc_tests::proposal_ibc_token_inflation": 1100,
     "e2e::ibc_tests::ibc_rate_limit": 430,
     "e2e::ibc_tests::ibc_namada_gaia": 180,
+    "e2e::ibc_tests::ibc_upgrade_client": 550,
     "e2e::eth_bridge_tests::test_add_to_bridge_pool": 10,
     "e2e::ledger_tests::double_signing_gets_slashed": 12,
     "e2e::ledger_tests::ledger_many_txs_in_a_block": 55,
@@ -25,6 +26,7 @@
     "e2e::ledger_tests::suspend_ledger": 30,
     "e2e::ledger_tests::stop_ledger_at_height": 18,
     "e2e::ledger_tests::change_consensus_key": 91,
+    "e2e::ledger_tests::test_localnet_genesis": 3,
     "e2e::wallet_tests::wallet_address_cmds": 1,
     "e2e::wallet_tests::wallet_encrypted_key_cmds": 1,
     "e2e::wallet_tests::wallet_encrypted_key_cmds_env_var": 1,

.github/workflows/scripts/hermes.txt

@@ -1 +1 @@
-1.9.0-namada-beta14-rc
+1.10.0-namada-beta15-rc2

CHANGELOG.md

@@ -1,5 +1,55 @@
 # CHANGELOG
 
+## v0.43.0
+
+Namada 0.43.0 is a minor relasing improving shielded sync and addressing some pre-genesis flow issues.
+
+### BUG FIXES
+
+- Fix genesis bonds from implicit accounts. Now, only addresses
+  of the form `tnam1...` are supported in `balances.toml`.
+  ([\#3645](https://github.com/anoma/namada/pull/3645))
+
+### FEATURES
+
+ - Partially addresses Issue [\#2900](https://github.com/anoma/namada/issues/2900). Viewing and spending keys can now
+   be given birthdays in the form of block heights which are loaded into 
+   shielded sync. Shielded sync will not try to decrypt a block before a 
+   keys birthday with said key. ([\#3653](https://github.com/anoma/namada/pull/3653))
+- The command `namadan utils test-genesis` now accepts `--check-can-sign`
+  multi-arg that can be used with genesis addresses and/or public keys to
+  verify that a pre-genesis wallet in the base directory is able to sign
+  with the keys associated with the addresses or with the keys themselves.
+  ([\#3660](https://github.com/anoma/namada/pull/3660))
+
+### IMPROVEMENTS
+
+- Removed parallel gas accounting.
+  ([\#3615](https://github.com/anoma/namada/pull/3615))
+- Improve governance client side validation.
+  ([\#3629](https://github.com/anoma/namada/pull/3629))
+- Masp vp and protocol now ensure that a transaction can push at most one MASP
+  action. ([\#3632](https://github.com/anoma/namada/pull/3632))
+- Do not load context for `namadan utils test-genesis` command.
+  ([\#3652](https://github.com/anoma/namada/pull/3652))
+- Speeds up client commands on networks with massive balances.toml
+  files. Previously, to retrieve the native token of some network,
+  we had to parse these giant files. Now, we only parse the
+  necessary genesis toml files required to retrieve the native token.
+  ([\#3655](https://github.com/anoma/namada/pull/3655))
+
+### SDK
+
+- Parallelize the shielded sync implementation in Namada.
+  ([\#3578](https://github.com/anoma/namada/pull/3578))
+
+### TESTING
+
+- Added fuzz testing targets for txs in mempool, block proposals and finalize
+  block. ([\#3445](https://github.com/anoma/namada/pull/3445))
+- Add IBC client upgrade test
+  ([\#3535](https://github.com/anoma/namada/issues/3535))
+
 ## v0.42.0
 
 Namada 0.42.0 is a minor release that includes refactor of crates dependency graph using dependency injection, improvements in client check and node's stability.
@@ -651,9 +701,6 @@ Namada 0.33.0 is a minor release that contains various new features, improvement
 
 - move query_ibc_tokens and lookup_ibc_token_alias to sdk
   ([\#2729](https://github.com/anoma/namada/issues/2729))
-
-### SDK
-
 - Add a new method to the sdk to change a validator consensus key.
   ([\#3037](https://github.com/anoma/namada/pull/3037))
 - Improve the function to update an enstablished address via the sdk.