add check on metadata name

anoma · Sep 8, 2024 · d51b59a · d51b59a
1 parent 59fdda8
commit d51b59a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/crates/apps_lib/src/config/genesis/transactions.rs b/crates/apps_lib/src/config/genesis/transactions.rs
@@ -1417,6 +1417,15 @@ pub fn validate_validator_account(
             );
         }
     }
+    if let Some(name) = metadata.name.as_ref() {
+        if name.len() as u64 > MAX_VALIDATOR_METADATA_LEN {
+            panic!(
+                "The name metadata of the validator with address {} is too \
+                 long, must be within {MAX_VALIDATOR_METADATA_LEN} characters",
+                signed_tx.data.address
+            );
+        }
+    }
 
     // Check signature
     let mut is_valid = {

diff --git a/crates/sdk/src/tx.rs b/crates/sdk/src/tx.rs
@@ -846,6 +846,18 @@ pub async fn build_validator_metadata_change(
             }
         }
     }
+    if let Some(name) = name.as_ref() {
+        if name.len() as u64 > MAX_VALIDATOR_METADATA_LEN {
+            edisplay_line!(
+                context.io(),
+                "Name provided is too long, must be within \
+                 {MAX_VALIDATOR_METADATA_LEN} characters"
+            );
+            if !tx_args.force {
+                return Err(Error::from(TxSubmitError::MetadataTooLong));
+            }
+        }
+    }
 
     // If there's a new commission rate, it must be valid
     if let Some(rate) = commission_rate.as_ref() {