Merge pull request #3617 from anoma/fraccaman/governance-proposal-cli…

…ent-better-hash

client: print sha256 of proposal wasm

.changelog/unreleased/improvements/3617-governance-proposal-client-better-hash.md

@@ -0,0 +1,2 @@
+- Display the hash of the proposal wasm code when querying proposals with
+  associated wasm payload. ([\#3617](https://github.com/anoma/namada/pull/3617))

crates/governance/src/storage/mod.rs

@@ -12,6 +12,7 @@ use std::collections::{BTreeMap, BTreeSet};
 use namada_core::address::Address;
 use namada_core::borsh::BorshDeserialize;
 use namada_core::collections::HashSet;
+use namada_core::hash::Hash;
 use namada_core::storage::Epoch;
 use namada_core::token;
 use namada_state::{
@@ -169,17 +170,29 @@ where
     let proposal_type: Option<ProposalType> =
         storage.read(&proposal_type_key)?;
 
-    let proposal = proposal_type.map(|proposal_type| StorageProposal {
+    let proposal_type = if let Some(proposal_type) = proposal_type {
+        if let ProposalType::DefaultWithWasm(_) = proposal_type {
+            let proposal_code_key = governance_keys::get_proposal_code_key(id);
+            let proposal_code: Vec<u8> =
+                storage.read(&proposal_code_key)?.unwrap_or_default();
+            let proposal_code_hash = Hash::sha256(proposal_code);
+            ProposalType::DefaultWithWasm(proposal_code_hash)
+        } else {
+            proposal_type
+        }
+    } else {
+        return Ok(None);
+    };
+
+    Ok(Some(StorageProposal {
         id,
         content: content.unwrap(),
         author: author.unwrap(),
         r#type: proposal_type,
         voting_start_epoch: voting_start_epoch.unwrap(),
         voting_end_epoch: voting_end_epoch.unwrap(),
         activation_epoch: activation_epoch.unwrap(),
-    });
-
-    Ok(proposal)
+    }))
 }
 
 /// Query all the votes for a proposal_id

crates/node/src/shell/governance.rs

@@ -122,14 +122,6 @@ where
             TallyResult::Passed => {
                 let proposal_event = match proposal_type {
                     ProposalType::Default => {
-                        let proposal_code =
-                            gov_api::get_proposal_code(&shell.state, id)?
-                                .unwrap_or_default();
-                        let _result = execute_default_proposal(
-                            shell,
-                            id,
-                            proposal_code.clone(),
-                        )?;
                         tracing::info!(
                             "Governance proposal #{} (default) has passed.",
                             id,
@@ -176,7 +168,7 @@ where
                     }
                     ProposalType::PGFPayment(payments) => {
                         let native_token = &shell.state.get_native_token()?;
-                        let _result = execute_pgf_funding_proposal(
+                        execute_pgf_funding_proposal(
                             &mut shell.state,
                             events,
                             native_token,