Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix possible panic in sig verification #3543

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 23, 2024

Describe your changes

The index op used to look-up signatures may fail if there isn't matching number of signatures.

Indicate on which release or other PRs this topic is based on

v0.40.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.47%. Comparing base (8479d38) to head (a8d74f0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3543      +/-   ##
==========================================
- Coverage   53.48%   53.47%   -0.01%     
==========================================
  Files         320      320              
  Lines      110000   110001       +1     
==========================================
- Hits        58832    58825       -7     
- Misses      51168    51176       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman mentioned this pull request Jul 23, 2024
@tzemanovic tzemanovic mentioned this pull request Jul 23, 2024
2 tasks
brentstone added a commit that referenced this pull request Jul 24, 2024
* tomas/fix-verify-sig-panic:
  tx: fix possible panic in sig verification
@tzemanovic tzemanovic marked this pull request as ready for review July 24, 2024 09:55
brentstone added a commit that referenced this pull request Jul 24, 2024
* tomas/fix-verify-sig-panic:
  changelog: add #3543
  tx: fix possible panic in sig verification
@brentstone brentstone merged commit f20ac6c into main Jul 24, 2024
17 of 19 checks passed
@brentstone brentstone deleted the tomas/fix-verify-sig-panic branch July 24, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants