workaround wasmer leak #3529
Merged
workaround wasmer leak #3529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
tzemanovic
force-pushed
the
tomas/leak-hunt
branch
from
ec0ec30
to
1098c97
Compare
tzemanovic
force-pushed
the
tomas/leak-hunt
branch
from
1098c97
to
1001f42
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3529 +/- ##
=======================================
Coverage 53.48% 53.49%
=======================================
Files 320 320
Lines 110000 110044 +44
=======================================
+ Hits 58832 58863 +31
- Misses 51168 51181 +13 ☔ View full report in Codecov by Sentry. |
|
tested on an internal network, can't reproduce the memory leak anymore 👍 |
tzemanovic
added a commit
that referenced
this pull request
Jul 23, 2024
tzemanovic
force-pushed
the
tomas/leak-hunt
branch
from
1001f42
to
b69a0fd
Compare
brentstone
added a commit
that referenced
this pull request
Jul 23, 2024
* tomas/leak-hunt: changelog: add #3529 workaround wasmer store segfault by keeping it in cache use a weak Rc in wasm memory to avoid leaking it
sug0
reviewed
Jul 24, 2024
sug0
approved these changes
Jul 24, 2024
tzemanovic
force-pushed
the
tomas/leak-hunt
branch
from
163d393
to
841dbf8
Compare
|
(squashed fixups) |
brentstone
added a commit
that referenced
this pull request
Jul 24, 2024
* tomas/leak-hunt: changelog: add #3529 workaround wasmer store segfault by keeping it in cache use a weak Rc in wasm memory to avoid leaking it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
workaround for wasmerio/wasmer#4377 and wasmerio/wasmer#4949
Indicate on which release or other PRs this topic is based on
v0.40.0
Checklist before merging to
draft