Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Ethereum token whitelist logic in Namada #1718

Closed
wants to merge 21 commits into from

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Jul 13, 2023

@sug0 sug0 changed the title Implement the Ethereum token whitelist on Namada Implement the Ethereum token whitelist logic in Namada Jul 13, 2023
@sug0 sug0 requested a review from cwgoes July 13, 2023 14:08
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from 5bcfeaf to fdcff0a Compare July 13, 2023 14:48
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from b2e39c6 to d3bbb45 Compare July 14, 2023 08:17
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several NUT test cases missing from the bridge pool vp. We should check the happy flow. We should check that we reject if an asset is incorrectly labelled. The bridge should also accept NUTs and normals for the same asset simultaneously.

@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch 3 times, most recently from 6df9350 to b4f4b8a Compare July 14, 2023 14:59
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from b4f4b8a to 1a5966b Compare July 14, 2023 16:02
@sug0
Copy link
Contributor Author

sug0 commented Jul 14, 2023

Took out the patch that removed ADDR from native VPs, and opened an issue

@sug0 sug0 requested a review from batconjurer July 14, 2023 16:03
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from 1a5966b to 5cef5df Compare July 15, 2023 09:16
@sug0
Copy link
Contributor Author

sug0 commented Jul 15, 2023

added a sanity check in 4b43593

        if hints::unlikely(cap < supply) {
            panic!(
                "Namada's state is faulty! The Ethereum ERC20 asset {token} \
                 has a higher minted supply than the configured token cap: \
                 cap:{cap:?} < supply:{supply:?}"
            );
        }

@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from 306d366 to e1b0e3e Compare July 15, 2023 13:11
@sug0 sug0 force-pushed the tiago/ethbridge/fake-mt-base branch from c933c91 to 713ba76 Compare July 15, 2023 13:12
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch 2 times, most recently from 5f29c91 to 65078b6 Compare July 15, 2023 13:28
@sug0 sug0 force-pushed the tiago/ethbridge/token-whitelist branch from 65078b6 to 353dc57 Compare July 25, 2023 10:37
@sug0 sug0 changed the base branch from tiago/ethbridge/fake-mt-base to main July 25, 2023 10:37
@sug0 sug0 marked this pull request as ready for review July 25, 2023 10:38
@sug0 sug0 closed this Jul 25, 2023
@sug0 sug0 deleted the tiago/ethbridge/token-whitelist branch July 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants