Switching to generic Amount branch of MASP crate. #1779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/masp-generic-amounts
branch
2 times, most recently
from
4529bbc
to
a7e80f6
Compare
batconjurer
requested changes
Aug 4, 2023
There was a problem hiding this comment.
So I gave up putting individual comments on every instance, but from looking at it, I think it is possible to avoid all mentions of the ValueSum type. Using the explicit type alias will prevent using the two different type names for the same object and hopefully lead to clearer code.
The other nit was about the FromNt name. Other than these naming things, looks good to me.
| @@ -658,7 +658,7 @@ pub fn tokens() -> HashMap<Address, (&'static str, Denomination)> { | |||
| /// Temporary helper for testing, a hash map of tokens addresses with their | |||
| /// MASP XAN incentive schedules. If the reward is (a, b) then a rewarded tokens | |||
| /// are dispensed for every b possessed tokens. | |||
| pub fn masp_rewards() -> HashMap<Address, (u64, u64)> { | |||
| pub fn masp_rewards() -> HashMap<Address, (u32, u32)> { | |||
There was a problem hiding this comment.
Was this a necessary change? Neither type can be safely cast to i32. Of course, we know all these values fit into i32.
murisi
force-pushed
the
murisi/masp-generic-amounts
branch
from
a7e80f6
to
6957c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Switched the MASP crate branch used by Namada to anoma/masp#52 . The specific changes are as follows:
*.tomlfiles to point to new MASP crate commit hashAllowedConversions are now represented byI32Sumsscripts/generator.shscript to facilitate testing of changesIndicate on which release or other PRs this topic is based on
Based on v0.20.1 .
Checklist before merging to
draft