Bat/pre genesis wallet #1782
Closed
Bat/pre genesis wallet #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
reviewed
Aug 3, 2023
tzemanovic
reviewed
Aug 3, 2023
tzemanovic
reviewed
Aug 3, 2023
tzemanovic
force-pushed
the
bat/pre-genesis-wallet
branch
from
b997d8f
to
65a07be
Compare
Closed
tzemanovic
approved these changes
Aug 3, 2023
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #849, this PR adds --pre-genesis argument to the wallet commands to allow to generate keys, implicit addresses and MASP keys without having a chain setup - this is a needed for #685. If no chain is setup yet (i.e. there's no .namada or it's empty), the wallet defaults to use the pre-genesis wallet even without the --pre-genesis flag. The pre-genesis wallet is located in .namada/pre-genesis/wallet.toml.
closes #784