Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGF over IBC #2243

Merged
merged 18 commits into from
Jan 13, 2024
Merged

PGF over IBC #2243

merged 18 commits into from
Jan 13, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Dec 4, 2023 •
edited
Loading

Describe your changes

closes #1395
CI for this PR requires Hermes: #2237

Indicate on which release or other PRs this topic is based on

#1797

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@yito88 yito88 force-pushed the yuji/pgf-ibc branch 2 times, most recently from 6269199 to f0888b6 Compare December 13, 2023 20:41
@yito88 yito88 marked this pull request as ready for review December 13, 2023 20:44
@Fraccaman
Copy link
Member

can you add the new e2e test to the e2e.json file pls

grarco
grarco previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@grarco grarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Fraccaman
Fraccaman previously approved these changes Dec 15, 2023
View reviewed changes
@Fraccaman Fraccaman mentioned this pull request Dec 28, 2023
Closed
@brentstone brentstone mentioned this pull request Dec 29, 2023
Closed
@yito88 yito88 dismissed stale reviews from Fraccaman and grarco via c4f0b4f January 2, 2024 23:36
@yito88
Copy link
Member Author

yito88 commented Jan 3, 2024

Rebased. I moved ibc.rs from app to core, which implements transfer_over_ibc for a protocol transaction because of conflict.
@Fraccaman @grarco Could you review it again?

tzemanovic added a commit that referenced this pull request Jan 9, 2024
@tzemanovic
Merge branch 'yuji/pgf-ibc' (#2243)
c5ba273 
* origin/yuji/pgf-ibc:
  fix to add the height in IBC event
  add new e2e
  add changelog
  add E2E test
  fix for 0.28.0
  add ibc
  pgf over ibc
@brentstone brentstone merged commit 3129de4 into main Jan 13, 2024
12 of 15 checks passed
@brentstone brentstone deleted the yuji/pgf-ibc branch January 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes left review comments

@grarco grarco grarco approved these changes

@Fraccaman Fraccaman Awaiting requested review from Fraccaman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CPGF & RPGF over IBC
6 participants
@yito88 @Fraccaman @cwgoes @grarco @tzemanovic @brentstone