Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix every typos #2269

Merged
merged 4 commits into from
Dec 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Namada 0.27.0 is a minor release that incorporates the remaining essential proof
can execute transactions that manipulate its own validator data
([\#2169](https://github.com/anoma/namada/pull/2169))
- Various improvements to the PoS code, including adding a panic on a slashing
failure, some more checked arithmetics, aesthetic code cleanup, and fixing a
failure, some more checked arithmetic, aesthetic code cleanup, and fixing a
bug in is_delegator. ([\#2178](https://github.com/anoma/namada/pull/2178))
- Added type tags to transactions to enable hardware wallets
to fully decode transactions even after minor Namada updates.
Expand Down Expand Up @@ -250,7 +250,7 @@ Namada 0.24.0 is a minor release that introduces an SDK crate, PoS redelegation,
data in storage. ([\#1944](https://github.com/anoma/namada/pull/1944))
- Query also IBC token balances
([\#1946](https://github.com/anoma/namada/issues/1946))
- Increased resoultion of gas accounting for signature verification.
- Increased resolution of gas accounting for signature verification.
([\#1954](https://github.com/anoma/namada/pull/1954))
- Refactor benchmarks to avoid enabling `"testing`" and `"dev"`` features by
default in the workspace.
Expand Down Expand Up @@ -553,7 +553,7 @@ stability.
show more info. ([\#1656](https://github.com/anoma/namada/pull/1656))
- Removed associated type on `masp::ShieldedUtils`. This type was an
attempt to reduce the number of generic parameters needed when interacting
with MASP but resulted in making code re-use extremely difficult.
with MASP but resulted in making code reuse extremely difficult.
([\#1670](https://github.com/anoma/namada/pull/1670))
- Removed `impl From<u64> for EthBridgeVotingPower` and replaced it with a
`TryFrom`. ([\#1692](https://github.com/anoma/namada/pull/1692))
Expand All @@ -568,7 +568,7 @@ stability.
ETH bridge. ([\#1693](https://github.com/anoma/namada/pull/1693))
- PoS: Keep the data for last two epochs by default.
([\#1733](https://github.com/anoma/namada/pull/1733))
- Refactored CLI into libraries for future re-use in integration tests and
- Refactored CLI into libraries for future reuse in integration tests and
to enable generic IO. ([\#1738](https://github.com/anoma/namada/pull/1738))

### TESTING
Expand Down Expand Up @@ -728,7 +728,7 @@ Namada 0.17.2 is a minor release featuring improvements to the client stability.
([\#1512](https://github.com/anoma/namada/pull/1512))
- Improve help message for address add command
([\#1514](https://github.com/anoma/namada/issues/1514))
- PoS: make a re-usable bonds and unbonds details query.
- PoS: make a reusable bonds and unbonds details query.
([\#1518](https://github.com/anoma/namada/pull/1518))

## v0.17.1
Expand Down Expand Up @@ -780,7 +780,7 @@ wallet address derivation, transaction structure and the ledger stability.
([\#1425](https://github.com/anoma/namada/issues/1425))
- Added some missing cli option for cli wallet
([#1432](https://github.com/anoma/namada/pull/1432))
- Improve logging error when submiting an invalid validator commission change tx
- Improve logging error when submitting an invalid validator commission change tx
([#1434](https://github.com/anoma/namada/pull/1434))
- Correct a typo in the error change commission error handling
([#1435](https://github.com/anoma/namada/pull/1435))
Expand Down Expand Up @@ -825,7 +825,7 @@ proposal.

### IMPROVEMENTS

- Make Tendermint consensus paramenters configurable via Namada configuration.
- Make Tendermint consensus parameters configurable via Namada configuration.
([#1399](https://github.com/anoma/namada/pull/1399))
- Improved error logs in `process_proposal` and added more info to
`InternalStats` ([#1407](https://github.com/anoma/namada/pull/1407))
Expand Down Expand Up @@ -1350,7 +1350,7 @@ integrations.

### BUG FIXES

- Fix compatiblity of IBC Acknowledgement message and FungibleTokenData with
- Fix compatibility of IBC Acknowledgement message and FungibleTokenData with
ibc-go ([#261](https://github.com/anoma/namada/pull/261))
- Fix the block header merkle root hash for response to finalizing block.
([#298](https://github.com/anoma/namada/pull/298))
Expand Down Expand Up @@ -1449,20 +1449,20 @@ Namada 0.8.0 is a regular minor release.
([#324](https://github.com/anoma/namada/pull/324))
- Added a StorageWrite trait for a common interface for transactions and direct
storage access for protocol ([#331](https://github.com/anoma/namada/pull/331))
- Re-use encoding/decoding storage write/read and handle any errors
- Reuse encoding/decoding storage write/read and handle any errors
([#334](https://github.com/anoma/namada/pull/334))
- Added a simpler prefix iterator API that returns `std::iter::Iterator` with
the storage keys parsed and a variant that also decodes stored values with
Borsh ([#335](https://github.com/anoma/namada/pull/335))
- Handles the case where a custom `$CARGO_TARGET_DIR` is set during WASM build
([#337](https://github.com/anoma/anoma/pull/337))
- Added `pre/post` methods into `trait VpEnv` that return objects implementing
`trait StorageRead` for re-use of library code written on top of `StorageRead`
`trait StorageRead` for reuse of library code written on top of `StorageRead`
inside validity predicates. ([#380](https://github.com/anoma/namada/pull/380))
- Fix order of prefix iterator to be sorted by storage
keys and add support for a reverse order prefix iterator.
([#409](https://github.com/anoma/namada/issues/409))
- Re-use `storage_api::Error` type that supports wrapping custom error in `VpEnv` and `TxEnv` traits.
- Reuse `storage_api::Error` type that supports wrapping custom error in `VpEnv` and `TxEnv` traits.
([#465](https://github.com/anoma/namada/pull/465))
- Fixed governance parameters, tally, tx whitelist and renamed treasury
([#467](https://github.com/anoma/namada/issues/467))
Expand All @@ -1474,7 +1474,7 @@ Namada 0.8.0 is a regular minor release.
- Added WASM transaction and validity predicate `Ctx` with methods for host
environment functions to unify the interface of native VPs and WASM VPs under
`trait VpEnv` ([#1093](https://github.com/anoma/anoma/pull/1093))
- Allows simple retrival of aliases from addresses in the wallet without
- Allows simple retrieval of aliases from addresses in the wallet without
the need for multiple hashmaps. This is the first step to improving the
UI if one wants to show aliases when fetching addresses from anoma wallet
([#1138](https://github.com/anoma/anoma/pull/1138))
Expand Down Expand Up @@ -1731,7 +1731,7 @@ Anoma 0.5.0 is a scheduled minor release.
- Dependency: Backport libp2p-noise patch that fixes a compilation
issue from <https://github.com/libp2p/rust-libp2p/pull/2264>
([#908](https://github.com/anoma/anoma/issues/908))
- Wasm: Re-add accidentaly removed `tx_ibc` WASM and `vm_env::ibc` module
- Wasm: Re-add accidentally removed `tx_ibc` WASM and `vm_env::ibc` module
([#916](https://github.com/anoma/anoma/pull/916))
- Ledger & Matchmaker: In "dev" chain with "dev" build, load WASM directly from
the root `wasm` directory. ([#933](https://github.com/anoma/anoma/issues/933))
Expand Down Expand Up @@ -1871,7 +1871,7 @@ Anoma 0.4.0 is a scheduled minor release, released 31 January 2022.
command. The command now doesn't unpack the network config archive into its
default directories, if any of them are specified with non-default values.
([#813](https://github.com/anoma/anoma/issues/813))
- Install the default token exchange matchmaker implemenetation into
- Install the default token exchange matchmaker implementation into
`~/.cargo/lib` directory when building from source. When not absolute, the
matchmaker will attempt to load the matchmaker from the same path as where the
binary is being ran from, from `~/.cargo/lib` or the current working
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ for i in $(ls -d .changelog/*/*/); do basename "$i"; done | sort | uniq

The Namada SDK is exposed to any developer building upon Namada. Thus, any change made to a public facing function is a breaking change, and therefore should be documented in the Changelog under the `SDK` section.

The message should outline the exact API change, along with a small section describing *how* and *why* the componenet was change. This should give motivation and context to any developer building upon Namada on how they can update their code to the next version.
The message should outline the exact API change, along with a small section describing *how* and *why* the component was change. This should give motivation and context to any developer building upon Namada on how they can update their code to the next version.

## Development priorities

Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ test-integration-save-proofs:
TEST_FILTER=masp \
make test-integration-slow

# Run integration tests without specifiying any pre-built MASP proofs option
# Run integration tests without specifying any pre-built MASP proofs option
test-integration-slow:
RUST_BACKTRACE=$(RUST_BACKTRACE) \
$(cargo) +$(nightly) test integration::$(TEST_FILTER) --features integration \
Expand Down Expand Up @@ -221,7 +221,7 @@ test-benches:
$(cargo) +$(nightly) test --package namada_benchmarks --benches

# Run PoS state machine tests with shrinking disabled by default (can be
# overriden with `PROPTEST_MAX_SHRINK_ITERS`)
# overridden with `PROPTEST_MAX_SHRINK_ITERS`)
test-pos-sm:
cd proof_of_stake && \
RUST_BACKTRACE=1 \
Expand Down
2 changes: 1 addition & 1 deletion apps/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ mainnet = [
"namada/mainnet",
]
std = ["ed25519-consensus/std", "rand/std", "rand_core/std", "namada/std", "namada_sdk/std"]
# for integration tests and test utilies
# for integration tests and test utilities
testing = ["namada_test_utils"]
benches = ["testing", "namada_test_utils"]
integration = []
Expand Down
6 changes: 3 additions & 3 deletions apps/src/lib/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1293,7 +1293,7 @@ pub mod cmds {

fn def() -> App {
App::new(Self::CMD)
.about("Query pgf stewards and continous funding.")
.about("Query pgf stewards and continuous funding.")
.add_args::<args::QueryPgf<args::CliTypes>>()
}
}
Expand Down Expand Up @@ -4784,7 +4784,7 @@ pub mod args {
.def()
.help(
"Flag if the proposal is of type pgf-funding. \
Used to control continous/retro pgf fundings.",
Used to control continuous/retro pgf fundings.",
)
.conflicts_with_all([
PROPOSAL_ETH.name,
Expand Down Expand Up @@ -6003,7 +6003,7 @@ pub mod args {
.arg(FEE_TOKEN.def().help("The token for paying the gas"))
.arg(FEE_UNSHIELD_SPENDING_KEY.def().help(
"The spending key to be used for fee unshielding. If none is \
provided, fee will be payed from the unshielded balance only.",
provided, fee will be paid from the unshielded balance only.",
))
.arg(GAS_LIMIT.def().help(
"The multiplier of the gas limit resolution defining the \
Expand Down
6 changes: 3 additions & 3 deletions apps/src/lib/client/rpc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1268,7 +1268,7 @@ pub async fn query_pgf(context: &impl Namada, _args: args::QueryPgf) {
true => {
display_line!(
context.io(),
"Pgf stewards: no stewards are currectly set."
"Pgf stewards: no stewards are currently set."
)
}
false => {
Expand Down Expand Up @@ -1375,7 +1375,7 @@ pub async fn query_protocol_parameters(
let epoch_duration: EpochDuration =
query_storage_value(context.client(), &key)
.await
.expect("Parameter should be definied.");
.expect("Parameter should be defined.");
display_line!(
context.io(),
"{:4}Min. epoch duration: {}",
Expand Down Expand Up @@ -2487,7 +2487,7 @@ pub async fn query_has_storage_key<
}

/// Call the corresponding `tx_event_query` RPC method, to fetch
/// the current status of a transation.
/// the current status of a transaction.
pub async fn query_tx_events<C: namada::ledger::queries::Client + Sync>(
client: &C,
tx_event_query: namada_sdk::rpc::TxEventQuery<'_>,
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/client/tx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ pub async fn with_hardware_wallet<'a, U: WalletIo + Clone>(
})?;
if response_pubkey != pubkey {
return Err(error::Error::Other(format!(
"Unrecognized public key fetched fom Ledger: {}. Expected {}.",
"Unrecognized public key fetched from Ledger: {}. Expected {}.",
response_pubkey, pubkey,
)));
}
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/client/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1157,5 +1157,5 @@ fn safe_exit(code: i32) -> ! {

#[cfg(test)]
fn safe_exit(code: i32) -> ! {
panic!("Process exited unsuccesfully with error code: {}", code);
panic!("Process exited unsuccessfully with error code: {}", code);
}
2 changes: 1 addition & 1 deletion apps/src/lib/config/genesis/transactions.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@ pub fn validate_established_account(

let established_address = tx.derive_address();
if tx.threshold == 0 {
eprintln!("An established account may not have zero thresold");
eprintln!("An established account may not have zero threshold");
is_valid = false;
}
if tx.threshold as usize > tx.public_keys.len() {
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/logging.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ fn rolling_freq() -> RollingFreq {
"daily" => RollingFreq::Daily,
_ => {
panic!(
"Unrecognized option set for {ROLLING_ENV_KEY}. Expecing \
"Unrecognized option set for {ROLLING_ENV_KEY}. Expecting \
one of: never, minutely, hourly, daily. Default is never."
);
}
Expand Down
4 changes: 2 additions & 2 deletions apps/src/lib/node/ledger/ethereum_oracle/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ impl<C: RpcClient> Oracle<C> {
true
}

/// Check if a new config has been sent from teh Shell.
/// Check if a new config has been sent from the Shell.
fn update_config(&mut self) -> Option<Config> {
match self.control.try_recv() {
Ok(Command::UpdateConfig(config)) => Some(config),
Expand Down Expand Up @@ -1169,7 +1169,7 @@ mod test_oracle {
controller
.apply_cmd(TestCmd::NewHeight(Uint256::from(synced_block_height)));

// check that the oracle still checks the blocks inbetween
// check that the oracle still checks the blocks in between
for height in (confirmed_block_height + 1)
..(confirmed_block_height + difference + 1)
{
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/node/ledger/shell/block_alloc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ mod tests {
proptest_reject_tx_on_bin_cap_reached(max)
}

/// Check if the initial bin capcity of the [`BlockAllocator`]
/// Check if the initial bin capacity of the [`BlockAllocator`]
/// is correct.
#[test]
fn test_initial_bin_capacity(max in prop::num::u64::ANY) {
Expand Down
6 changes: 3 additions & 3 deletions apps/src/lib/node/ledger/shell/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,7 @@ where
{
response.code = ErrorCodes::InvalidVoteExtension.into();
response.log = format!(
"{INVALID_MSG}: Invalid Brige pool roots vote \
"{INVALID_MSG}: Invalid Bridge pool roots vote \
extension: {err}",
);
} else {
Expand Down Expand Up @@ -1564,7 +1564,7 @@ where
ValidatorSetUpdate::Deactivated(consensus_key) => {
// Any validators that have been dropped from the
// consensus set must have voting power set to 0 to
// remove them from the conensus set
// remove them from the consensus set
let power = 0_i64;
(consensus_key, power)
}
Expand Down Expand Up @@ -1926,7 +1926,7 @@ mod test_utils {

/// Config parameters to set up a test shell.
pub struct SetupCfg<H> {
/// The last comitted block height.
/// The last committed block height.
pub last_height: H,
/// The number of validators to configure
// in `InitChain`.
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/node/ledger/shell/process_proposal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ where
TxResult {
code: ErrorCodes::Ok.into(),
info: "Process Proposal accepted this \
tranasction"
transaction"
.into(),
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ where

/// Takes an iterator over Bridge pool root vote extension instances,
/// and returns another iterator. The latter yields
/// valid Brige pool root vote extensions, or the reason why these
/// valid Bridge pool root vote extensions, or the reason why these
/// are invalid, in the form of a `VoteExtensionError`.
#[inline]
pub fn validate_bp_roots_vext_list<'iter>(
Expand Down
2 changes: 1 addition & 1 deletion apps/src/lib/wallet/defaults.rs
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ mod dev {
.into_owned()
}

/// Get an unecrypted keypair from the pre-genesis wallet.
/// Get an unencrypted keypair from the pre-genesis wallet.
pub fn get_unencrypted_keypair(name: &str) -> common::SecretKey {
let sk = match PREGENESIS_WALLET.get_secret_keys().get(name).unwrap().0
{
Expand Down
4 changes: 2 additions & 2 deletions apps/src/lib/wallet/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ impl WalletIo for CliWalletUtils {

// The given alias has been selected but conflicts with another alias in
// the store. Offer the user to either replace existing mapping, alter the
// chosen alias to a name of their chosing, or cancel the aliasing.
// chosen alias to a name of their choosing, or cancel the aliasing.
fn show_overwrite_confirmation(
alias: &Alias,
alias_for: &str,
Expand Down Expand Up @@ -187,7 +187,7 @@ pub fn read_and_confirm_passphrase_tty(
/// Generate keypair
/// for signing protocol txs and for the DKG (which will also be stored)
/// A protocol keypair may be optionally provided, indicating that
/// we should re-use a keypair already in the wallet
/// we should reuse a keypair already in the wallet
pub fn gen_validator_keys<U: WalletIo>(
wallet: &mut Wallet<U>,
eth_bridge_pk: Option<common::PublicKey>,
Expand Down
2 changes: 1 addition & 1 deletion benches/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ The benchmarks are built with [criterion.rs](https://bheisler.github.io/criterio

Measurements are taken on the elapsed wall-time.

The benchmarks only focus on sucessfull transactions and vps: in case of failure, the bench function shall panic to avoid timing incomplete execution paths.
The benchmarks only focus on successful transactions and vps: in case of failure, the bench function shall panic to avoid timing incomplete execution paths.

In addition, this crate also contains benchmarks for `WrapperTx` (`namada::core::types::transaction::wrapper::WrapperTx`) validation and `host_env` (`namada::vm::host_env`) exposed functions that define the gas constants of `gas` (`namada::core::ledger::gas`).

Expand Down
Loading
Loading