-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft+2260+2220+2310+2285 #2339
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d checked arithmetic operations to DenominatedAmount to catch mistakes.
…pe is attached. Integration tests now work.
…ate tree from the tx
…and report all errors found
* tiago/eth-tx-emits-events: Changelog for #1995 SDK changelog update SDK method to query status of selected Bridge pool transfers Implement serde serialization for transfer to eth statuses Return Ethereum bridge events from FinalizeBlock Emit Bridge pool tx events Test Bridge pool transfer status Optimize Bridge pool transfer status RPC query RPC method to query status of selected Bridge pool transfers Add Ethereum bridge tx events
* origin/main: makefile: use single thread to run integration test
* bat/feat/dry-run: test: use tempdirs for genesis artifacts [fix]: Addressing review comments [chore]: Add changelog [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
Before the code would bind a variable just for creating a path, we abstract this out with some functions Further I started to remove the rather verbose file creation
This was an unused function that simply repeated the logic of the non async version
Instead of expecting right away and placing a literal string, we can instead abstract the commonalities of the strings into the error type This shows off a lot of similarities between write_* functions, that can now be cleanly abstracted
After the previous commits the write_validator_state and write_validator_key were basically the same modulo some error parameters and minor state details
Before the function had 3 phases, that was jumbled into 1 whole. There was: 1. setup 2. running 3. response handling Since this structure is rather well defined, and not much data is shared between these phases, we just turn the function into dispatching into functions that reprsent each stage
Namada 0.28.2 is a patch release that fixes a stack overflow issue for nodes. * tag 'v0.28.2': Namada 0.28.2 changelog: add #2325 fix replay_protection iterator to avoid unmatched keys rocksdb: warn on unmatched prefix in iterator rocksdb: replace recursion from prefix iterator with a loop update hermes
* mariari/basic-abstraction: changelog: add #2127 Abstract `tendermint_node::run` into 3 distinct phases Abstract out the commanality in write tendermint Abstract out file error messages with the error type Remove write_validator repace manua path with functions. Start abstraction on file creation
…rebased' into draft * origin/aleks/wallet-cli-revamping-main-rebased: Add changelog Remove unused import Fix messages Adapt e2e tests to new wallet cli Improve decryption status line Improve output if keypair could not be decypted Fix export / import Minor Fix key import Implement `remove` command Expose store remove_alias functionality Allow to add public keys Refactoring Fix `find` command; refactoring Fix key / address listing Adapt e2e tests for new wallet cli Fix help message Improve comment Refactor parsing of `add` command value Improve message Merge find-key and find-addr Reverse find alias for payment address Store known payment addresses in bimap Improve help messages Fix typo Merge key and address list Fix comments and help messages Import key from file Implement raw key add; simplify cli for add command Improve some messages, comments Implement export for MASP spending keys Update help messages for `gen` and `derive` Fix output message Add todo Fix: normalize alias strings Make `--alias` obligatory for gen / derive Refactoring Rename structures Restore raw key generation functionality Refactor payment key gen Unify cli for key export / add Refactor key export Unify cli for transparent / shielded key / address listing / searching Unify cli for transparent / shielded key listing Unify cli for secret / spending key derivation Unify cli for secret / spending key generation
* origin/adrian/light-sdk: Adds a method to serialize transactions Makes internal struct of `RevealPk` private Fixes datetime Splits light sdk queries into multiple files Renames light sdk crate and adds description Adds missing feature for tendermint-rpc in light sdk Changelog #2220 Imports `HttpClient` from `tendermint_rpc` Updates types and imports after rebase Updates docstrings and fixes clippy Some small type simplifications in the reading api [feat]: Added rpc functions to light sdk Renames `get_msg_to_sign` to `get_sign_bytes` [feat]: Small fixes and making stuff public First draft of all transactions in light sdk Refactors pos txs in separate file. Improved shared functions Created light SDK builders. First attempt at overview of light-sdk
* origin/bat/feat/wait-for-genesis: [fix]: Don't spawn another async task to shutdown while waiting for genesis. Addressing review comments [fix]: Fixed english changelog [fix]: Make the ledger wait for genesis before starting up any processes
* origin/bat/fix/masp-rewards-genesis: [feat]: Added an rpc endpoint to query which tokens can earn MASP rewards while shielded [chore]: Add changelog [fix]: Masp conversions no longer requires all tokens be present in genesis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.