Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+2260+2220+2310+2285+2311+2315 #2341

Closed
wants to merge 268 commits into from

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Dec 27, 2023

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

murisi and others added 30 commits December 4, 2023 18:18
…d checked arithmetic operations to DenominatedAmount to catch mistakes.
* tomas/vp-less-permissive:
  additions from comments
  wasm/vp_user+vp_implicit: update for IBC actions
  benches: fix foreign key write tx sigs
  wasm/vp_user+vp_implicit: always print rejected keys
  wasm/vp_user+vp_implicit: impl PoS key checks
  changelog: add #2213
  wasm/vp_implicit: require valid sig for unknown changes
  wasm/vp_user: require valid sig for unknown changes
  wasm/vp_implicit: port Masp and PgfSteward key handling from vp_user
  wasm/vp_user: fix a typo
* origin/grarco/masp-cross-epoch-proof-fix:
  Changelog #2222
  Updates masp fixtures for tests
  Refactors `convert_amount`
  Tests masp cross-epoch unshield
  Allows unshielding assets from previous epochs
batconjurer and others added 29 commits December 21, 2023 16:13
* tiago/eth-tx-emits-events:
  Changelog for #1995
  SDK changelog update
  SDK method to query status of selected Bridge pool transfers
  Implement serde serialization for transfer to eth statuses
  Return Ethereum bridge events from FinalizeBlock
  Emit Bridge pool tx events
  Test Bridge pool transfer status
  Optimize Bridge pool transfer status RPC query
  RPC method to query status of selected Bridge pool transfers
  Add Ethereum bridge tx events
* origin/main:
  makefile: use single thread to run integration test
* bat/feat/dry-run:
  test: use tempdirs for genesis artifacts
  [fix]: Addressing review comments
  [chore]: Add changelog
  [feat]: Added a cli command to dry run init-chain with genesis files and report all errors found
Before the code would bind a variable just for creating a path, we
abstract this out with some functions

Further I started to remove the rather verbose file creation
This was an unused function that simply repeated the logic of the non
async version
Instead of expecting right away and placing a literal string, we can
instead abstract the commonalities of the strings into the error type

This shows off a lot of similarities between write_* functions, that
can now be cleanly abstracted
After the previous commits the write_validator_state and
write_validator_key were basically the same modulo some error
parameters and minor state details
Before the function had 3 phases, that was jumbled into 1 whole.

There was:
1. setup
2. running
3. response handling

Since this structure is rather well defined, and not much data is
shared between these phases, we just turn the function into
dispatching into functions that reprsent each stage
Namada 0.28.2 is a patch release that fixes a stack overflow issue for nodes.

* tag 'v0.28.2':
  Namada 0.28.2
  changelog: add #2325
  fix replay_protection iterator to avoid unmatched keys
  rocksdb: warn on unmatched prefix in iterator
  rocksdb: replace recursion from prefix iterator with a loop
  update hermes
* mariari/basic-abstraction:
  changelog: add #2127
  Abstract `tendermint_node::run` into 3 distinct phases
  Abstract out the commanality in write tendermint
  Abstract out file error messages with the error type
  Remove write_validator
  repace manua path with functions. Start abstraction on file creation
…rebased' into draft

* origin/aleks/wallet-cli-revamping-main-rebased:
  Add changelog
  Remove unused import
  Fix messages
  Adapt e2e tests to new wallet cli
  Improve decryption status line
  Improve output if keypair could not be decypted
  Fix export / import
  Minor
  Fix key import
  Implement `remove` command
  Expose store remove_alias functionality
  Allow to add public keys
  Refactoring
  Fix `find` command; refactoring
  Fix key / address listing
  Adapt e2e tests for new wallet cli
  Fix help message
  Improve comment
  Refactor parsing of `add` command value
  Improve message
  Merge find-key and find-addr
  Reverse find alias for payment address
  Store known payment addresses in bimap
  Improve help messages
  Fix typo
  Merge key and address list
  Fix comments and help messages
  Import key from file
  Implement raw key add; simplify cli for add command
  Improve some messages, comments
  Implement export for MASP spending keys
  Update help messages for `gen` and `derive`
  Fix output message
  Add todo
  Fix: normalize alias strings
  Make `--alias` obligatory for gen / derive
  Refactoring
  Rename structures
  Restore raw key generation functionality
  Refactor payment key gen
  Unify cli for key export / add
  Refactor key export
  Unify cli for transparent / shielded key / address listing / searching
  Unify cli for transparent / shielded key listing
  Unify cli for secret / spending key derivation
  Unify cli for secret / spending key generation
* origin/adrian/light-sdk:
  Adds a method to serialize transactions
  Makes internal struct of `RevealPk` private
  Fixes datetime
  Splits light sdk queries into multiple files
  Renames light sdk crate and adds description
  Adds missing feature for tendermint-rpc in light sdk
  Changelog #2220
  Imports `HttpClient` from `tendermint_rpc`
  Updates types and imports after rebase
  Updates docstrings and fixes clippy
  Some small type simplifications in the reading api
  [feat]: Added rpc functions to light sdk
  Renames `get_msg_to_sign` to `get_sign_bytes`
  [feat]: Small fixes and making stuff public
  First draft of all transactions in light sdk
  Refactors pos txs in separate file. Improved shared functions
  Created light SDK builders.
  First attempt at overview of light-sdk
* origin/bat/feat/wait-for-genesis:
  [fix]: Don't spawn another async task to shutdown while waiting for genesis.
  Addressing review comments
  [fix]: Fixed english
  changelog
  [fix]: Make the ledger wait for genesis before starting up any processes
* origin/bat/fix/masp-rewards-genesis:
  [feat]: Added an rpc endpoint to query which tokens can earn MASP rewards while shielded
  [chore]: Add changelog
  [fix]: Masp conversions no longer requires all tokens be present in genesis
* origin/yuji/fix-ibc-gen-shielded:
  add SDK changelog
  fix parsing token address
  add changelog
  non-namada token to ibc-gen-shielded
@grarco grarco closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants