Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MASP vp panics #2345

Merged
merged 6 commits into from
Jan 13, 2024
Merged

MASP vp panics #2345

merged 6 commits into from
Jan 13, 2024

Conversation

grarco
Copy link
Contributor

@grarco grarco commented Dec 28, 2023

Describe your changes

Removes panics from the native masp vp. Introduces helper functions to construct masp keys.

Indicate on which release or other PRs this topic is based on

v0.29.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

grarco added a commit that referenced this pull request Dec 29, 2023
grarco added a commit that referenced this pull request Jan 2, 2024
@grarco grarco marked this pull request as ready for review January 2, 2024 11:23
@tzemanovic tzemanovic mentioned this pull request Jan 4, 2024
@grarco grarco mentioned this pull request Jan 9, 2024
2 tasks
tzemanovic added a commit that referenced this pull request Jan 9, 2024
* origin/grarco/masp-vp-panics:
  Changelog #2345
  Clippy + fmt
  SDK uses core helper functions for masp keys
  Refactors `masp_commitment_anchor_key` to be generic
  Helper functions for masp keys
  Removes panics from masp vp
@brentstone brentstone merged commit 6f5b22f into main Jan 13, 2024
14 of 15 checks passed
@brentstone brentstone deleted the grarco/masp-vp-panics branch January 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants