Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disentangle Ethereum events logic from vote extensions #243

Merged
merged 25 commits into from
Aug 4, 2022
Merged

Disentangle Ethereum events logic from vote extensions #243

merged 25 commits into from
Aug 4, 2022

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Aug 1, 2022 •
edited
Loading

Implements the first item of issue #242

This process is quite boring, and I may not catch all references of vote extension which were really meant to reference Ethereum events. Therefore, future PRs may be needed to rename everything that's left.

@sug0 sug0 marked this pull request as ready for review August 2, 2022 15:18
@sug0 sug0 mentioned this pull request Aug 2, 2022
Closed
james-chf
james-chf reviewed Aug 2, 2022
View reviewed changes
Copy link
Contributor

@james-chf james-chf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're adding a lot of TODO comments to the code, I think some of these could better come in (implemented) in the next PR.

apps/src/lib/node/ledger/shell/prepare_proposal.rs Outdated Show resolved Hide resolved
shared/src/types/vote_extensions/ethereum_events.rs Outdated Show resolved Hide resolved
shared/src/types/vote_extensions/ethereum_events.rs Outdated Show resolved Hide resolved
apps/src/lib/node/ledger/shell/vote_extensions.rs Outdated Show resolved Hide resolved
batconjurer
batconjurer approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments, but generally looks good

@sug0 sug0 requested a review from james-chf August 3, 2022 09:07
@sug0 sug0 merged commit 49fbdae into eth-bridge-integration Aug 4, 2022
@sug0 sug0 deleted the tiago/ethbridge/vext-refactor branch August 4, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-chf james-chf james-chf approved these changes

@batconjurer batconjurer batconjurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sug0 @batconjurer @james-chf