Checked arithmetic in multitoken vp #2441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
commented
Jan 25, 2024
Comment on lines
81
to
83
| // Check if the minter is set | ||
| if !self.is_valid_minter(token, verifiers)? { | ||
| return Ok(false); | ||
| } |
There was a problem hiding this comment.
I moved this condition at the beginning, hopefully is fine
Fraccaman
force-pushed
the
fraccaman/fix-multitoken-arithmetic
branch
from
cdb360c
to
414de6d
Compare
Closed
|
Closed in favor of #2443 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft