Murisi/masp separate parallel sync #2474
Conversation
…ization function.
| fn parse(matches: &ArgMatches) -> Self { | ||
| let ledger_address = LEDGER_ADDRESS_DEFAULT.parse(matches); | ||
| let last_query_height = BLOCK_HEIGHT_OPT.parse(matches); | ||
| let viewing_keys = VIEWING_KEYS.parse(matches); |
There was a problem hiding this comment.
do we not want to support passing in spending keys here?
There was a problem hiding this comment.
Whenever a spending key is added to the wallet, its corresponding viewing key is also added under the same name. So I'm thinking that that this code should be sufficient for now. No?
There was a problem hiding this comment.
Sure, I just wondered if we considered it important.
crates/apps/src/lib/cli/client.rs
Outdated
| .collect::<Vec<_>>(); | ||
| let mut shielded = namada.shielded_mut().await; | ||
| let _ = shielded.load().await; | ||
| for vk in wallet_keys { |
There was a problem hiding this comment.
Let's leave the internals of vk heights inside of the sync function. Instead lets concatenate all of the keys together and pass them into the shielded sync function.
| } | ||
| // the latest block height which has been added to the witness Merkle |
There was a problem hiding this comment.
I'm actually surprised that the integration tests pass. There is bug here that one failed for me on. We need to save the shielded context here to persist the keys.
Describe your changes
This PR creates a separate synchronization command and heavily draws code from #2422 . More specifically, this PR's changes are as follows:
shielded-syncshielded-syncs before doing any actionsIndicate on which release or other PRs this topic is based on
#2458
Checklist before merging to
draft