Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Murisi/masp separate parallel sync rebased #2479

Closed
wants to merge 9 commits into from

Conversation

murisi
Copy link
Contributor

@murisi murisi commented Jan 31, 2024

Describe your changes

This PR creates a separate synchronization command and heavily draws code from #2422 . More specifically, this PR's changes are as follows:

  • Parallelized the downloading of transactions with the scanning of transactions and updating of the note Merkle tree
    • This reduces the wall-clock time required to synchronize the shielded context
    • This allows us to avoid having to cache downloaded transactions until transaction scanning starts
  • Created a separate command to synchronize the shielded context called shielded-sync
  • Adjusted all other commands to no longer implicitly synchronize the shielded pool before executing their actions
  • Modified the synchronization function to save state frequently so that the interrupted and resumed without data loss
  • Adjusted the integration tests so that they now explicitly do shielded-syncs before doing any actions

Indicate on which release or other PRs this topic is based on

Namada v0.30.3

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@murisi murisi marked this pull request as ready for review January 31, 2024 11:32
@brentstone
Copy link
Collaborator

Is this still relevant? @batconjurer @grarco

@batconjurer
Copy link
Member

Is this still relevant? @batconjurer @grarco

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants