-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/mock masp prover #2695
Merged
Merged
Murisi/mock masp prover #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/mock-masp-prover
branch
from
February 22, 2024 12:59
aa5e421
to
8a4d782
Compare
murisi
force-pushed
the
murisi/mock-masp-prover
branch
2 times, most recently
from
February 22, 2024 13:06
6253bb2
to
28fc780
Compare
murisi
force-pushed
the
murisi/mock-masp-prover
branch
from
February 22, 2024 14:13
2669415
to
53dca3d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
- Coverage 53.38% 53.34% -0.04%
==========================================
Files 302 302
Lines 103403 103469 +66
==========================================
- Hits 55198 55196 -2
- Misses 48205 48273 +68 ☔ View full report in Codecov by Sentry. |
2 tasks
tzemanovic
approved these changes
Feb 23, 2024
grarco
approved these changes
Feb 23, 2024
tzemanovic
added a commit
that referenced
this pull request
Feb 26, 2024
* murisi/mock-masp-prover: masp: move the mock stuff under testing sub-mod Added changelog entry. Do not allow MASP_TEST_SEED to be used outside of testing. Implemented a MockSaplingVerificationContext and enable it for testing flag. Modified the transaction generator to use mock prover when in testing mode.
brentstone
added a commit
that referenced
this pull request
Mar 4, 2024
* murisi/mock-masp-prover: masp: move the mock stuff under testing sub-mod Added changelog entry. Do not allow MASP_TEST_SEED to be used outside of testing. Implemented a MockSaplingVerificationContext and enable it for testing flag. Modified the transaction generator to use mock prover when in testing mode.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replaced the test fixture saving system with a mock MASP prover and verifier system. More specifically:
testing
flag is enabled, the mock prover and verifier are now activated instead of the real onestest-integration
commandThe advantages/drawbacks of the above system are as follows:
make
targets are required for testing the MASP clientIndicate on which release or other PRs this topic is based on
Namada 0.31.5
anoma/masp#72
Checklist before merging to
draft