-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a validator alias field to validator metadata #2911
Conversation
this looks nice! a couple of things are left to be done:
Thanks for your contribution! |
@Fraccaman Done! I've also created a PR to fix the command used to generate localnet files, since one of the flag values has a wrong path. #3044 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 59.40% 59.37% -0.04%
==========================================
Files 298 298
Lines 92326 92389 +63
==========================================
+ Hits 54849 54853 +4
- Misses 37477 37536 +59 ☔ View full report in Codecov by Sentry. |
@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself. |
@brentstone I'm trying to figure out how to do it correctly, but I don't want to mess up anything - so, yes, I'd be fine if you do so instead in order to avoid conflicts. Thanks :) |
0d4d1a0
to
2dc8997
Compare
@brentstone Done. I just gave you write access just in case I've made any mistake. |
2dc8997
to
5eecf81
Compare
5eecf81
to
fb6be58
Compare
* McDaan-validator-alias: change to validator name (from validator alias) fix tests Changelog generating localnet files add validator alias field to metadata
* McDaan-validator-alias: test change to validator name (from validator alias) fix tests Changelog generating localnet files add validator alias field to metadata
* mcdaan/McDaan-validator-alias: test change to validator name (from validator alias) fix tests Changelog generating localnet files add validator alias field to metadata
Describe your changes
Closes #2910
Indicate on which release or other PRs this topic is based on
v0.34.0
Checklist before merging to
draft