Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validator alias field to validator metadata #2911

Merged
merged 6 commits into from
May 9, 2024

Conversation

McDaan
Copy link
Contributor

@McDaan McDaan commented Mar 18, 2024

Describe your changes

Closes #2910

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman
Copy link
Member

Fraccaman commented Mar 20, 2024

this looks nice! a couple of things are left to be done:

  • regenerate the localnet files in genesis/localnet
  • re-run make fmt

Thanks for your contribution!

@brentstone brentstone modified the milestone: To evaluate Apr 6, 2024
@McDaan
Copy link
Contributor Author

McDaan commented Apr 10, 2024

this looks nice! a couple of things are left to be done:

  • regenerate the localnet files in genesis/localnet
  • re-run make fmt

Thanks for your contribution!

@Fraccaman Done!

I've also created a PR to fix the command used to generate localnet files, since one of the flag values has a wrong path. #3044

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 7.93651% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 59.37%. Comparing base (9d4de02) to head (294519c).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/proof_of_stake/src/storage.rs 8.00% 23 Missing ⚠️
crates/proof_of_stake/src/storage_key.rs 0.00% 6 Missing ⚠️
crates/sdk/src/args.rs 0.00% 6 Missing ⚠️
crates/light_sdk/src/transaction/pos.rs 0.00% 4 Missing ⚠️
crates/proof_of_stake/src/lib.rs 0.00% 4 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 4 Missing ⚠️
crates/tx_prelude/src/proof_of_stake.rs 0.00% 4 Missing ⚠️
crates/sdk/src/lib.rs 0.00% 3 Missing ⚠️
crates/apps/src/lib/config/genesis/transactions.rs 33.33% 2 Missing ⚠️
crates/sdk/src/queries/vp/pos.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   59.40%   59.37%   -0.04%     
==========================================
  Files         298      298              
  Lines       92326    92389      +63     
==========================================
+ Hits        54849    54853       +4     
- Misses      37477    37536      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman mentioned this pull request Apr 15, 2024
@brentstone
Copy link
Collaborator

@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.

@McDaan
Copy link
Contributor Author

McDaan commented Apr 15, 2024

@McDaan Can you rebase this PR on the latest release v0.33? Alternatively, let me know if you'd be fine with me cleaning this up a bit myself.

@brentstone I'm trying to figure out how to do it correctly, but I don't want to mess up anything - so, yes, I'd be fine if you do so instead in order to avoid conflicts. Thanks :)

@McDaan
Copy link
Contributor Author

McDaan commented Apr 16, 2024

@brentstone Done. I just gave you write access just in case I've made any mistake.

@brentstone brentstone requested a review from tzemanovic May 2, 2024 22:08
tzemanovic
tzemanovic previously approved these changes May 3, 2024
brentstone added a commit that referenced this pull request May 7, 2024
* McDaan-validator-alias:
  change to validator name (from validator alias)
  fix tests
  Changelog
  generating localnet files
  add validator alias field to metadata
brentstone added a commit that referenced this pull request May 7, 2024
* McDaan-validator-alias:
  test
  change to validator name (from validator alias)
  fix tests
  Changelog
  generating localnet files
  add validator alias field to metadata
brentstone added a commit that referenced this pull request May 8, 2024
* mcdaan/McDaan-validator-alias:
  test
  change to validator name (from validator alias)
  fix tests
  Changelog
  generating localnet files
  add validator alias field to metadata
@brentstone brentstone merged commit a11b18b into anoma:main May 9, 2024
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to fetch validator alias because it's not part of validator metadata
4 participants