Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create basic disperse command for cli #2945

Closed
wants to merge 2 commits into from

Conversation

colomvax
Copy link

@colomvax colomvax commented Mar 22, 2024

Describe your changes

This PR is a suggestion of addition for a new command in the CLI for Namada, which could be very useful for a data protection oriented blockchain.
It gets its inspiration from the "disperse" contract on Ethereum, which allows a user to send X to N addresses in one single transaction.

I know the implementation is not perfect/complete, because as it is, it sends N txs, instead of a single one, but Im not advanced enough in Rust or my comprehension of Namada codebase to go further than that. But I hope this provides a useful starter to add this command !

This would probably benefit from having its own VP and wasm, as it looks a lot like a simple transfer but to be able to run it in a single tx, it requires to wrap multiple tx inside the inner/wrapper txs. Not sure how to do that, way beyond me 😄

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@cwgoes
Copy link
Contributor

cwgoes commented May 22, 2024

Very nice, thank you for the contribution! We've recently added batch transaction support (many inner transactions in one) - I'm wondering, would that address the use-case you have in mind here?

@grarco
Copy link
Contributor

grarco commented Sep 9, 2024

I believe this was implemented in #3459

@Fraccaman
Copy link
Member

As @grarco said, this was implemented in #3459, closing this! Thanks for the PR anyway!

@Fraccaman Fraccaman closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants