-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor shielded sync #3006
Refactor shielded sync #3006
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3006 +/- ##
==========================================
+ Coverage 54.05% 54.73% +0.67%
==========================================
Files 315 319 +4
Lines 106296 107702 +1406
==========================================
+ Hits 57461 58952 +1491
+ Misses 48835 48750 -85 ☔ View full report in Codecov by Sentry. |
33f5189
to
08a3b7f
Compare
174c5d2
to
3bcaee8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, just need to investigate the failing tests
What's the status of this? Can we get it on a 0.35.1 base? @batconjurer @grarco |
I believe we haven't figured out yet the issue with the tests in CI |
3bcaee8
to
24481a0
Compare
24481a0
to
103a249
Compare
1ceece0
to
ca44b7b
Compare
b03d473
to
5bc4268
Compare
Closed in favor of #3385 |
Describe your changes
This PR refactors shielded sync to make the following improvements
The new architecture of the algorithm can be found here
N.B. The integration tests seem flaky on the CI, although I can't reproduce any of it locally. It's unclear to me if it is due to the changes in this PR.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft