-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/multi tx masp vp experiments #3177
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sapling bundle anymore
…oves unchecked operation.
murisi
force-pushed
the
murisi/multi-tx-masp-vp-experiments
branch
from
May 6, 2024 15:26
aaa5904
to
098ee65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Tried to increase the readability, strength, and generality of the MASP validity predicate whilst decreasing its verbosity. The changes are as follows:
Transaction
inputs and outputs that exceed pre-balances and post-balances respectively are no longer allowed.AssetType
decoding in one place before starting to check the transparent bundlesTransaction
s and unrelatedTransfer
s touching the same addresses/tokensTransaction
s and the balancing transaction are sufficiently authorized; prevents malleabilityWhat would still need to be handled/fixed if this code turns out to be relevant:
ValueSum::new
objectsAmount
s during the value balance computations inverify_sapling_balancing_value
Transaction
to Bertha is embeddable inside aTransfer
to Christel only if Bertha has signed the entire transaction (in addition to the usual MASP checks).Indicate on which release or other PRs this topic is based on
#2690
Checklist before merging to
draft