Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependencies #3218

Merged
merged 15 commits into from
May 21, 2024
Merged

Clean up dependencies #3218

merged 15 commits into from
May 21, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented May 9, 2024

Describe your changes

Closes #1024.
Mostly addresses #1023.

Indicate on which release or other PRs this topic is based on

v0.35.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 60.24%. Comparing base (4ed6229) to head (e93db4a).

Files Patch % Lines
crates/sdk/src/args.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
- Coverage   60.24%   60.24%   -0.01%     
==========================================
  Files         303      303              
  Lines       93191    93191              
==========================================
- Hits        56145    56144       -1     
- Misses      37046    37047       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone changed the title Remove unused dependencies Clean up dependencies May 9, 2024
@brentstone brentstone marked this pull request as ready for review May 15, 2024 23:51
crates/core/Cargo.toml Outdated Show resolved Hide resolved
crates/sdk/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small things - other than that LGTM!

tzemanovic added a commit that referenced this pull request May 17, 2024
* origin/brent/cleanup-dependencies:
  changelog: add #3218
  respond to comments
  upgrade tracing-log
  use updated fork of tiny-hderive
  use regex workspace
  de-duplicate itertools by upgrading itself and tonic-build
  upgrade ed25519-consensus
  replace dep `parse_duration` with `duration-str`
  update shlex
  update rustls
  update mio
  update libgit2-sys
  update h2
  update eyre
  remove unused dependencies
brentstone added a commit that referenced this pull request May 17, 2024
* brent/cleanup-dependencies:
  changelog: add #3218
  respond to comments
  upgrade tracing-log
  use updated fork of tiny-hderive
  use regex workspace
  de-duplicate itertools by upgrading itself and tonic-build
  upgrade ed25519-consensus
  replace dep `parse_duration` with `duration-str`
  update shlex
  update rustls
  update mio
  update libgit2-sys
  update h2
  update eyre
  remove unused dependencies
brentstone added a commit that referenced this pull request May 21, 2024
* origin/brent/cleanup-dependencies:
  changelog: add #3218
  respond to comments
  upgrade tracing-log
  use updated fork of tiny-hderive
  use regex workspace
  de-duplicate itertools by upgrading itself and tonic-build
  upgrade ed25519-consensus
  replace dep `parse_duration` with `duration-str`
  update shlex
  update rustls
  update mio
  update libgit2-sys
  update h2
  update eyre
  remove unused dependencies
@tzemanovic tzemanovic merged commit 2ee654c into main May 21, 2024
14 of 19 checks passed
@tzemanovic tzemanovic deleted the brent/cleanup-dependencies branch May 21, 2024 13:29
@brentstone brentstone mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo Udeps
2 participants