Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove masp vp dependency on Transfer #3232

Merged
merged 13 commits into from
May 31, 2024
Merged

Conversation

grarco
Copy link
Contributor

@grarco grarco commented May 13, 2024

Describe your changes

Closes #3148.
Partially addresses #2597.

Removes the last dependency on Transfer from the masp vp by using a new masp Action. Creates a new event for this and updated the sdk to fetch data relying on this event.

Indicate on which release or other PRs this topic is based on

v0.37.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 42.30769% with 165 lines in your changes are missing coverage. Please review.

Project coverage is 53.93%. Comparing base (6dc1612) to head (ef33d62).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp.rs 0.00% 102 Missing ⚠️
crates/namada/src/ledger/native_vp/masp.rs 0.00% 17 Missing ⚠️
crates/node/src/bench_utils.rs 0.00% 12 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 90.00% 8 Missing ⚠️
crates/core/src/masp.rs 0.00% 7 Missing ⚠️
crates/node/src/shell/finalize_block.rs 80.00% 5 Missing ⚠️
crates/node/src/shell/governance.rs 0.00% 5 Missing ⚠️
crates/state/src/wl_state.rs 61.53% 5 Missing ⚠️
crates/tx/src/action.rs 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
+ Coverage   53.89%   53.93%   +0.03%     
==========================================
  Files         314      314              
  Lines      105704   105739      +35     
==========================================
+ Hits        56968    57027      +59     
+ Misses      48736    48712      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grarco grarco force-pushed the grarco/masp-no-transfer-dep branch 2 times, most recently from f4eeb94 to 9989051 Compare May 23, 2024 10:52
grarco added a commit that referenced this pull request May 23, 2024
@grarco grarco marked this pull request as ready for review May 23, 2024 15:54
@grarco grarco requested review from batconjurer and murisi May 23, 2024 15:54
@grarco grarco requested a review from tzemanovic May 23, 2024 16:12
@grarco grarco force-pushed the grarco/masp-no-transfer-dep branch from 375182e to 4bf8fcc Compare May 24, 2024 08:13
@tzemanovic tzemanovic mentioned this pull request May 29, 2024
2 tasks
brentstone added a commit that referenced this pull request May 30, 2024
* origin/grarco/masp-no-transfer-dep:
  Fmt
  Changelog #3232
  Fixes broken doc link
  Reworks masp tx indexing
  Helper function for masp action handling
  Moves masp events data to core
  Misc refactors
  Updates sdk to retrieve masp data based on events
  Emit masp sections references in the events
  Removes unused error variant
  Updates wasm transaction to push masp action
  Removes masp vp dependency on `Transfer`
  Adds new masp `Action`
@brentstone brentstone merged commit 7183603 into main May 31, 2024
17 of 19 checks passed
@brentstone brentstone deleted the grarco/masp-no-transfer-dep branch May 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Transfer dependency in MASP vp
4 participants