Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup #3235

Merged
merged 4 commits into from
May 31, 2024
Merged

Minor cleanup #3235

merged 4 commits into from
May 31, 2024

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented May 13, 2024

Describe your changes

Some minor cleanup, including more deps cleanup.

Indicate on which release or other PRs this topic is based on

v0.37.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.79%. Comparing base (c7d79f4) to head (c235d66).
Report is 2 commits behind head on main.

Current head c235d66 differs from pull request most recent head caf33e8

Please upload reports for the commit caf33e8 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3235      +/-   ##
==========================================
- Coverage   53.79%   53.79%   -0.01%     
==========================================
  Files         314      314              
  Lines      105784   105784              
==========================================
- Hits        56903    56902       -1     
- Misses      48881    48882       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.89%. Comparing base (6dc1612) to head (c8eb326).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3235      +/-   ##
==========================================
- Coverage   53.89%   53.89%   -0.01%     
==========================================
  Files         314      314              
  Lines      105704   105704              
==========================================
- Hits        56968    56965       -3     
- Misses      48736    48739       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone marked this pull request as ready for review May 24, 2024 04:51
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tzemanovic added a commit that referenced this pull request May 24, 2024
* origin/brent/minor-cleanup:
  WIPPP
  remove folder
  remove unused deps
  improve `ValidatorState` documentation
brentstone added a commit that referenced this pull request May 30, 2024
* origin/brent/minor-cleanup:
  WIPPP
  remove folder
  remove unused deps
  improve `ValidatorState` documentation
@brentstone brentstone merged commit ec27e3f into main May 31, 2024
17 of 19 checks passed
@brentstone brentstone deleted the brent/minor-cleanup branch May 31, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants