Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx_ibc wasm again #3275

Merged
merged 5 commits into from
May 24, 2024
Merged

tx_ibc wasm again #3275

merged 5 commits into from
May 24, 2024

Conversation

yito88
Copy link
Member

@yito88 yito88 commented May 20, 2024

Describe your changes

Closes #1831
Revert the workaround for the issue, which is by using the temporary host_env function for IBC.
It still requires floating-point support.

Indicate on which release or other PRs this topic is based on

v0.36.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 53.85%. Comparing base (c7d79f4) to head (e1c2812).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/ibc/src/actions.rs 0.00% 6 Missing ⚠️
crates/namada/src/ledger/native_vp/ibc/context.rs 0.00% 6 Missing ⚠️
crates/tx_prelude/src/ibc.rs 40.00% 3 Missing ⚠️
crates/ibc/src/lib.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3275      +/-   ##
==========================================
+ Coverage   53.79%   53.85%   +0.06%     
==========================================
  Files         314      314              
  Lines      105784   105661     -123     
==========================================
+ Hits        56903    56906       +3     
+ Misses      48881    48755     -126     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yito88 yito88 mentioned this pull request May 22, 2024
2 tasks
@yito88
Copy link
Member Author

yito88 commented May 22, 2024

hmm, it still requires floating-point support. It didn't work after #3209.

The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Shell(LoadingWasm("Invalid WASM using forbidden features: floating-point support is disabled (at offset 0x26fc1). Expected: WasmFeatures { mutable_global: false, saturating_float_to_int: false, si
gn_extension: true, reference_types: false, multi_value: false, bulk_memory: false, simd: false, relaxed_simd: false, threads: false, tail_call: false, floats: false, multi_memory: false, exceptions: false, memory64: false, extended_const: false, comp
onent_model: false, function_references: false, memory_control: false, gc: false }"))
Location: /Users/yuji/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tower-abci-0.14.0/src/v037/server.rs:179

@yito88 yito88 requested a review from tzemanovic May 22, 2024 20:58
@yito88 yito88 marked this pull request as ready for review May 22, 2024 20:58
@@ -260,28 +260,6 @@ fn run_ledger_ibc_with_hermes() -> Result<()> {
wait_for_packet_relay(&port_id_a, &channel_id_a, &test_a)?;
check_balances_after_back(&port_id_b, &channel_id_b, &test_a, &test_b)?;

// Transfer a token and it will time out and refund
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removed test was duplicated

tzemanovic
tzemanovic previously approved these changes May 23, 2024
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM, but I think we better investigate and remove the usage of the floats (we can do it as a follow-up). I had a look and some usage comes from tendermint-rs and its use serde_json which should be easy to replace by serde_json_wasm

tzemanovic added a commit that referenced this pull request May 23, 2024
* yuji/tx-ibc-wasm:
  gas: remove unused ibc tx gas
  remove allowed_txs bench
  add changelog
  enable floating-point support
  tx_ibc wasm again
brentstone added a commit that referenced this pull request May 23, 2024
* origin/yuji/tx-ibc-wasm:
  gas: remove unused ibc tx gas
  remove allowed_txs bench
  add changelog
  enable floating-point support
  tx_ibc wasm again
@brentstone brentstone merged commit 107e498 into main May 24, 2024
16 of 19 checks passed
@brentstone brentstone deleted the yuji/tx-ibc-wasm branch May 24, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling tx_ibc.wasm on the ledger failed on M1 Mac
4 participants