Replay protection contributes to App Hash #3284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3284 +/- ##
==========================================
+ Coverage 53.79% 53.80% +0.01%
==========================================
Files 314 314
Lines 105784 105828 +44
==========================================
+ Hits 56903 56941 +38
- Misses 48881 48887 +6 ☔ View full report in Codecov by Sentry. |
sug0
reviewed
May 21, 2024
sug0
requested changes
May 22, 2024
sug0
reviewed
May 22, 2024
…d and contributes to the total app hash
Co-authored-by: Tiago Carvalho <[email protected]>
Co-authored-by: Tiago Carvalho <[email protected]>
batconjurer
force-pushed
the
bat/reprot-merklized-commitment
branch
from
0b44ee9
to
c7d358c
Compare
sug0
previously approved these changes
May 22, 2024
tzemanovic
added a commit
that referenced
this pull request
May 23, 2024
* origin/bat/reprot-merklized-commitment: Fix write to storage Only initialize a hasher if necessary Reworking hash concatenation Update crates/core/src/address.rs Update crates/core/src/address.rs changelog [feat]: A commitment to all replay protection entries is now merklized and contributes to the total app hash
brentstone
added a commit
that referenced
this pull request
May 23, 2024
* origin/bat/reprot-merklized-commitment: Fix write to storage Only initialize a hasher if necessary Reworking hash concatenation Update crates/core/src/address.rs Update crates/core/src/address.rs changelog [feat]: A commitment to all replay protection entries is now merklized and contributes to the total app hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Replay protection entries need to be verifiable and thus should contribute to the app hash. This PR makes a cryptographic commitment to all replay protection entries (the root of some implicit merkle tree) which is itself merklized.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft