Enforce fee payment #3294
Merged
Enforce fee payment #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3294 +/- ##
==========================================
+ Coverage 53.89% 53.93% +0.04%
==========================================
Files 314 314
Lines 105704 105804 +100
==========================================
+ Hits 56968 57069 +101
+ Misses 48736 48735 -1 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/force-fee-payment
branch
from
14cddbe
to
64fca34
Compare
batconjurer
reviewed
May 23, 2024
batconjurer
previously approved these changes
May 23, 2024
tzemanovic
reviewed
May 23, 2024
tzemanovic
reviewed
May 23, 2024
tzemanovic
reviewed
May 23, 2024
tzemanovic
previously approved these changes
May 23, 2024
grarco
force-pushed
the
grarco/force-fee-payment
branch
from
69857d6
to
e82d57d
Compare
tzemanovic
added a commit
that referenced
this pull request
May 24, 2024
* origin/grarco/force-fee-payment: Fmt Changelog #3075 Fixes typo Misc adjustments to v36 Adds integration test for enforced fees Removes useless operations on wrapper transactions Removes useless check on tx type for reprot management Fixes unit tests Pass tx by reference in `apply_wrapper_tx` Removes unused wasm caches for wrapper execution Refactors the arguments of `dispatch_tx` for every tx type Cache wrapper transaction to avoid second deserialization Reorganizes arguments for tx execution Refactors tx execution of `finalize_block` into separate functions Fixes fee payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3075.
Restructures
finalize_blockto collect the fees from all the transactions before executing the inner txs, putting this back in line with the validation logic ofprocess_proposaland removing an attack vector.Indicate on which release or other PRs this topic is based on
v0.37.0
Checklist before merging to
draft