Start including MASP randomness in the test vectors. #3296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3296 +/- ##
==========================================
- Coverage 53.79% 53.78% -0.01%
==========================================
Files 314 314
Lines 105784 105784
==========================================
- Hits 56903 56896 -7
- Misses 48881 48888 +7 ☔ View full report in Codecov by Sentry. |
grarco
previously approved these changes
May 23, 2024
cwgoes
previously approved these changes
May 27, 2024
murisi
force-pushed
the
murisi/test-vectors-with-randomness2
branch
from
8bfcbec
to
eff67bb
Compare
murisi
added a commit
that referenced
this pull request
May 27, 2024
2 tasks
brentstone
added a commit
that referenced
this pull request
May 30, 2024
* origin/murisi/test-vectors-with-randomness2: Added a changelog entry. Start including MASP randomness in the test vectors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Augment the MASP test vectors with the used randomness parameters. Also add the schema for the randomness parameters to the
tx-schemaexample.Indicate on which release or other PRs this topic is based on
Namada v0.26.1
anoma/masp#84
Checklist before merging to
draft